Date: Tue, 22 Nov 2011 20:14:50 +0100 From: Robert Millan <rmh@freebsd.org> To: Ed Schouten <ed@80386.nl> Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>, freebsd-current@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers Message-ID: <CAOfDtXN1PTP=2NW966Xg2EjC8Hs4id2tzY7tsM8t6i1RLE66Xw@mail.gmail.com> In-Reply-To: <20111122185300.GC1979@hoeg.nl> References: <CAOfDtXMFk%2BC_eUsb6190UHHM0cgu3jf1M_M9oq4ibuYuke4pYQ@mail.gmail.com> <CAOfDtXP6ShN3DezN0u4PUVt9ft__2a%2BYwo3in9w01eQnfAQ7sQ@mail.gmail.com> <20111119175620.GV50300@deviant.kiev.zoral.com.ua> <20111120114042.GA1256@thorin> <20111120174807.GY50300@deviant.kiev.zoral.com.ua> <20111121133954.A1108@besplex.bde.org> <20111121092749.GD50300@deviant.kiev.zoral.com.ua> <CAOfDtXNypUhu-dWznLyHcZMN-ZPSn_qTC6pSuL68r2M2hOjZTg@mail.gmail.com> <20111122093515.GK50300@deviant.kiev.zoral.com.ua> <20111122175340.GA44367@thorin> <20111122185300.GC1979@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ed, 2011/11/22 Ed Schouten <ed@80386.nl>: >> +#undef __FreeBSD_kernel__ >> +#define __FreeBSD_kernel__ > > So why not remove the #undef and not let the compiler define it at all? Well I have no objection if the #undef is removed. I don't understand why you consider it a problem though. It's not terribly useful but if compilers can opt in and define it (usually as an empty macro), this doesn't hurt either AFAICT. The problem I described before was about compilers being forced to provide a number. Anyhow, I don't think it makes a big difference.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXN1PTP=2NW966Xg2EjC8Hs4id2tzY7tsM8t6i1RLE66Xw>