From owner-svn-src-stable@freebsd.org  Fri May 11 23:37:07 2018
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC66EFD45EC
 for <svn-src-stable@mailman.ysv.freebsd.org>;
 Fri, 11 May 2018 23:37:07 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from pmta2.delivery6.ore.mailhop.org
 (pmta2.delivery6.ore.mailhop.org [54.200.129.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 547F175513
 for <svn-src-stable@freebsd.org>; Fri, 11 May 2018 23:37:07 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 3e582c92-5574-11e8-b234-5d9545c6b53f
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound2.ore.mailhop.org (Halon) with ESMTPSA
 id 3e582c92-5574-11e8-b234-5d9545c6b53f;
 Fri, 11 May 2018 23:37:19 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w4BNavNL068046;
 Fri, 11 May 2018 17:36:57 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1526081817.2597.5.camel@freebsd.org>
Subject: Re: svn commit: r333503 - stable/11/sys/net
From: Ian Lepore <ian@freebsd.org>
To: "Jonathan T. Looney" <jtl@freebsd.org>, Stephen Hurd <shurd@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Date: Fri, 11 May 2018 17:36:57 -0600
In-Reply-To: <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com>
References: <201805112040.w4BKeQvO053076@repo.freebsd.org>
 <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2018 23:37:08 -0000

On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote:
> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd@freebsd.org> wrote:
> > 
> > 
> > Author: shurd
> > Date: Fri May 11 20:40:26 2018
> > New Revision: 333503
> > URL: https://svnweb.freebsd.org/changeset/base/333503
> > 
> > Log:
> >   MFC r333329, r333366, r333373
> > 
> >   r333329: Fix off-by-one error requesting tx interrupt
> >   r333366: Cleanup queues when iflib_device_register fails
> >   r333373: Log iflib_tx_structures_setup failure in function
> > 
> Is this an acceptable style for MFC logs?
> 
> I'm asking because I actually prefer this to reading (or compiling) the
> concatenated log messages from several changes. However, I never knew it
> was acceptable to summarize like this. If it is, I'd like to know so I can
> adopt it for run-of-the-mill MFCs.
> 
> Jonathan

This used to be my preferred format, essentially to summarize what's
being mfc'd. But then I started using the MFC Tracker tool [*] and it
automatically generates a commit message that contains the full text,
so I stopped trying to summarize things.

[*] https://mfc.kernelnomicon.org/6/

-- Ian