From owner-svn-src-user@FreeBSD.ORG  Mon Dec  2 22:21:02 2013
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C92C6A53;
 Mon,  2 Dec 2013 22:21:02 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A0B04105F;
 Mon,  2 Dec 2013 22:21:02 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 97797B917;
 Mon,  2 Dec 2013 17:21:01 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Glen Barber <gjb@freebsd.org>
Subject: Re: svn commit: r258848 - user/hrs/releng/release
Date: Mon, 2 Dec 2013 16:13:30 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; )
References: <201312021440.rB2EeQa6012210@svn.freebsd.org>
 <20131202145103.GG1839@glenbarber.us>
In-Reply-To: <20131202145103.GG1839@glenbarber.us>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201312021613.30872.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 02 Dec 2013 17:21:01 -0500 (EST)
Cc: Hiroki Sato <hrs@freebsd.org>, src-committers@freebsd.org,
 svn-src-user@freebsd.org
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user/>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Dec 2013 22:21:02 -0000

On Monday, December 02, 2013 9:51:03 am Glen Barber wrote:
> On Mon, Dec 02, 2013 at 02:40:26PM +0000, Hiroki Sato wrote:
> > Author: hrs
> > Date: Mon Dec  2 14:40:26 2013
> > New Revision: 258848
> > URL: http://svnweb.freebsd.org/changeset/base/258848
> > 
> > Log:
> >   Improve robustness and consistency, and remove redundant lines with no
> >   major functional change:
> 
> > [...]
> 
> > +if [ $($ID -u) -ne 0 ]; then
> > +	echo 1>&2 "$0: Needs to be run as root."
> > +	exit 1
> > +fi
> >  # The directory within which the release will be built.
> > -CHROOTDIR="/scratch"
> > +: ${CHROOTDIR:=/scratch}
> > +: ${CHROOT_CMD:=chroot $CHROOTDIR}
> > +: ${DESTDIR=:/R/}
> > +: ${MAKEOBJDIRPREFIX:=/usr/obj}
> >  
> 
> Please do not merge these changes to head/.  It was intentional that
> environment was not honored, as everything should be set in the
> configuration file.
> 
> It is possible to use the environment in the configuration file, such
> as:
> 
> ---- release.conf ----
> : ${_DESTDIR=:/R/}
> DESTDIR=${_DESTDIR}
> ---- release.conf ----

OTOH, I have hacked release.sh at my work specifically in this manner
since I use a wrapper script to invoke release.sh and don't want to have
to create a temporary file, etc.  I tried using this approach for
release.conf when you suggested and it did not work IIRC.

-- 
John Baldwin