From nobody Wed Aug 2 09:47:03 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RG7V96nxxz4qTy1; Wed, 2 Aug 2023 10:28:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RG6Zj6D6sz42n4; Wed, 2 Aug 2023 09:47:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690969630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iTsOADh88cgTa2AwqThcK+2xo8djfUnWgoNN5WdHVL8=; b=TCmoPeam3SEPFC7ljEVSaT1qJ0dOG41tvUTqa+HNKHfY+spLGC/EETJWffPR5+4oTrEeCn c1k3/8eexkrf+gqGC3Hp2wgto6tv1nse/JLeask8Z3ExRrxwMcS36bNnklMlUCt7p9+uIN Kl+D2Gu7rrPXLBpqYsdN+A3u/av4kPOhDErT+r+YlUM31RZFoi0BtzF843j0cjVuU9ywI3 9GqrYZPh7Gzo75wF/lbpZ0wpyobfGVy91oBSM571tq7WLJaSaWfsojZvaWYuJHEy3oPV6g UbrVe8+hu8Vk9ur9IUQ64KrhPN6A8t2jTHMzQ3F8be42E5uRX4xMptFcPUqFHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690969630; a=rsa-sha256; cv=none; b=OBMzRn8wzLQG9LGKjuMLGLpVXv3zPpoQpa02uIIvnSQr7oPeFJLkcdFNtSkHN5ZouSlfqG Qqag7tvjiVl3DJ1PaS7wRNyF3GS1PMw/dqI8iQGipkCoqJV3X8Wt9uitRvBaLPGfMlygDx wJup1e8ECE13OJweg9l0oQr7mcbpd3PukOihD5syM2wHbqdb7/uwLekW3L2DU+Y0AFwGxn p+nL7U8oKAsj6p0Q8bJQFn0gsx54DmpnfUbAbaY5gLO+KwOW/w5VZwKCLw5Ko4IteyAS2c 8Yj2cFU1kBTPxs5GjtfH0QqIdLAY1mm6JyXd1ImYk0zcwyuBF8im1lvEGcACxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690969630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iTsOADh88cgTa2AwqThcK+2xo8djfUnWgoNN5WdHVL8=; b=A31ZayPIqyGvjNZ7SHJcelxGkjzs8tZc7jVv6yxdXnqqYodp9wx3D76xYkGYBPAFbXjMYA DY7ZL2GFw8mC0OJHT6yolaPEB90D0m35ZfT5zl1ioZZZP8Rm1IrEsjtw8Jfrqu4eYc985h Enm5NjC7rvC+zCsw8qrEHrjNrWccar8ZFqfqAAuAwMstij5gIqNF/0pF9KbmqgUsRfvIWR Pv/zrX3yR/4rXkPXBjNmgQhLou8jwpa+rff2KKSV0M4ilRmsxtudTs34hQWBwrDkfqKCxu 2l0Od1nzQFXZb1+ty3aplxm+furJlpaVoN9xP9UgATbgNVkhpOJr4Cb5Qwdx8A== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RG6Zg690Tz19x1; Wed, 2 Aug 2023 09:47:06 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 48A064D561; Wed, 2 Aug 2023 11:47:04 +0200 (CEST) From: Kristof Provost To: Doug Moore Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1a7fcf6d51eb - main - vm_phys_enqueue_contig: handle npages==0 Date: Wed, 02 Aug 2023 11:47:03 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: <5A7123CD-C471-4DAA-8CFA-20BC3E9B1A64@FreeBSD.org> In-Reply-To: References: <202308020314.3723ETgj027830@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2 Aug 2023, at 11:36, Kristof Provost wrote: > On 2 Aug 2023, at 5:14, Doug Moore wrote: >> The branch main has been updated by dougm: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D1a7fcf6d51eb67ee3e05fdb= b806f7e68f9f53c9c >> >> commit 1a7fcf6d51eb67ee3e05fdbb806f7e68f9f53c9c >> Author: Doug Moore >> AuthorDate: 2023-08-02 03:12:00 +0000 >> Commit: Doug Moore >> CommitDate: 2023-08-02 03:12:00 +0000 >> >> vm_phys_enqueue_contig: handle npages=3D=3D0 >> >> By letting vm_phys_enqueue_contig handle the case when npages =3D=3D= 0, >> the callers can stop checking it, and the compiler can stop >> zero-checking with every call to ffs(). Letting vm_phys_enqueue_co= ntig >> call vm_phys_enqueue_contig for part of its work also saves a few >> bytes. >> >> The amd64 object code shrinks by 80 bytes. >> >> Reviewed by: kib >> Differential Revision: https://reviews.freebsd.org/D41154 > > I suspect this commit caused my machine to fail to boot: > > WARNING: WITNESS option enabled, expect reduced performance.c data=3D= 0x180 data=3D0x > panic: vm_phys_enq_range: page 0xfffffe0000006180 and npages 429496= 7040 are misaligned > cpuid =3D 0onfigured modules... > time =3D 1rnel/if_bnxt.ko size 0x3efe8 at 0x1f50000 > KDB: stack backtrace:ize 0x6f2698 at 0x1f8f000 > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffff= fff82c03e20 > vpanic() at vpanic+0x149/frame 0xffffffff82c03e70 > panic() at panic+0x43/frame 0xffffffff82c03ed00 > vm_phys_enq_range() at vm_phys_enq_range+0x11d/frame 0xffffffff82c0= 3ee0 > vm_phys_enqueue_contig() at vm_phys_enqueue_contig+0xdd/frame 0xfff= fffff82c03f20 > vm_page_startup() at vm_page_startup+0xf3d/frame 0xffffffff82c03f90= > vm_mem_init() at vm_mem_init+0x1a/frame 0xffffffff82c03fa0 > mi_startup() at mi_startup+0x1f1/frame 0xffffffff82c03ff0 > btext() at btext+0x23 > KDB: enter: panic > > This is sufficiently early in boot that I don=E2=80=99t get a core dump= , so I hope the backtrace helps you. > > I=E2=80=99ll back out the commit locally and confirm. > And confirmed. With this commit reverted the machine boots again. Best regards, Kristof