From owner-freebsd-stable@freebsd.org Thu Oct 29 19:36:16 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E5D545BDB9 for ; Thu, 29 Oct 2020 19:36:16 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CMbKC2gM2z4Fh8; Thu, 29 Oct 2020 19:36:14 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 09TJaDrh024584 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 29 Oct 2020 12:36:13 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 09TJaD1O024583; Thu, 29 Oct 2020 12:36:13 -0700 (PDT) (envelope-from jmg) Date: Thu, 29 Oct 2020 12:36:13 -0700 From: John-Mark Gurney To: sreehari Cc: Kurt Jaeger , "FreeBSD-stable@FreeBSD.org" Subject: Re: 12.2-RC1: RTL8251/8153 1000BASE-T seemingly stuck at 100Mbps Message-ID: <20201029193613.GL31099@funkthat.com> Mail-Followup-To: sreehari , Kurt Jaeger , "FreeBSD-stable@FreeBSD.org" References: <20201007223858.GS4213@funkthat.com> <20201008043602.GV53210@home.opsec.eu> <20201008063620.GT4213@funkthat.com> <20201008075314.GU4213@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Thu, 29 Oct 2020 12:36:14 -0700 (PDT) X-Rspamd-Queue-Id: 4CMbKC2gM2z4Fh8 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [0.01 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jmg]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_LONG(-0.23)[-0.231]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.52)[-0.515]; NEURAL_HAM_MEDIUM(-0.45)[-0.448]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; MAILMAN_DEST(0.00)[FreeBSD-stable]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 19:36:16 -0000 sreehari wrote this message on Thu, Oct 08, 2020 at 16:04 -0700: > ok I tried cherry picking the commit from head to stable/12 according to > one person's suggestion and I get some hunk failed's when i try patch -C > -p0. Is there any way I can simulate the MFC? Sorry I'm just not familiar > with svn Sorry, I missed this reply... I'll be merging the change into stable/12 in the comming week... > On Thu, Oct 8, 2020, 00:53 John-Mark Gurney wrote: > > > sreehari wrote this message on Wed, Oct 07, 2020 at 23:56 -0700: > > > I see. Since I have the hardware and freebsd head seems broken on my > > > laptop, I'll try compiling stable/12 with the ure patch from head within > > > the next few days. I have gigabit internet and other machines to test the > > > ethernet with the full 1000Mbps. Are there any actions you suggest I take > > > to benchmark or stress test the hardware or make sure everything is > > working > > > properly? > > > > Nothing in particular... iperf or iperf3 works well... do normal > > transfers and make sure you don't see packet drops that are unexpected > > (checksumming was enabled)... If you have vlans, use those... Just be > > aware of any unexpected behaviors.. > > > > Thanks for the additional testing! And letting mek now that it works > > is useful! > > > > > On Wed, Oct 7, 2020, 23:36 John-Mark Gurney wrote: > > > > > > > Kurt Jaeger wrote this message on Thu, Oct 08, 2020 at 06:36 +0200: > > > > > > sreehari wrote this message on Tue, Oct 06, 2020 at 21:02 -0700: > > > > > > > I have a USB C hub that supports gigabit ethernet under any > > other OS, > > > > > > > but under FreeBSD it seems to detect it properly, but I never get > > > > > > > speeds exceeding 100Mbps transfer rate on the whole thing. Is > > this a > > > > > > > known issue? Also is there any way to check what the perceived > > link > > > > > > > speed is? I've attached dmesg.boot if that helps. > > > > > > > > > > > > This is a known issue w/ the ure driver on FreeBSD. This has been > > > > > > fixed in -current, and in a few months I'll look at merging it to > > > > > > stable/12, but it definitly will not make the 12.2 release: > > > > > > https://reviews.freebsd.org/D25809 > > > > > > > > > > The changes seem to be limited to the driver itself -- is some > > > > > structural change in 13 stopping a merge to 12.2 ? > > > > > > > > The issue is that IMO, it's too close to the release of 12.2. It only > > > > recently got committed to 13, and so hasn't had enough time to be > > tested > > > > in more environments than mine. There have been a few others that have > > > > tested it. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."