From owner-freebsd-fs@FreeBSD.ORG Mon Jun 19 15:37:30 2006 Return-Path: X-Original-To: freebsd-fs@FreeBSD.org Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EFB016A484 for ; Mon, 19 Jun 2006 15:37:30 +0000 (UTC) (envelope-from arne_woerner@yahoo.com) Received: from web30312.mail.mud.yahoo.com (web30312.mail.mud.yahoo.com [68.142.201.230]) by mx1.FreeBSD.org (Postfix) with SMTP id 9B10643D46 for ; Mon, 19 Jun 2006 15:37:29 +0000 (GMT) (envelope-from arne_woerner@yahoo.com) Received: (qmail 97390 invoked by uid 60001); 19 Jun 2006 15:37:29 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=ZaGEWRJRjtkO1iHBi3QUYXGFI/SRrUFu992aIfu7tHPsosqK/avFP36umVMxpvmaqcbTlviJazocYRfqJVMk9WMgY/weTHTeZ6dZSwW1DIs0YV4THKjLo6xRvP0U8KtTJMd0DoqxWiYhDXOEx88LvrDIbBt4kmeh+WMOrA3rrJs= ; Message-ID: <20060619153729.97388.qmail@web30312.mail.mud.yahoo.com> Received: from [213.54.84.110] by web30312.mail.mud.yahoo.com via HTTP; Mon, 19 Jun 2006 08:37:29 PDT Date: Mon, 19 Jun 2006 08:37:29 -0700 (PDT) From: "R. B. Riddick" To: Pawel Jakub Dawidek In-Reply-To: <20060619143231.GF1130@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: freebsd-fs@FreeBSD.org Subject: Re: Journaling UFS with gjournal. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2006 15:37:30 -0000 --- Pawel Jakub Dawidek wrote: > On Mon, Jun 19, 2006 at 06:37:06AM -0700, R. B. Riddick wrote: > +> --- Pawel Jakub Dawidek wrote: > +> > 2. If we have file system, synchronize it. > +> > 3. Mark file system as clean. > +> > 4. Block all write requests to the file system. > +> > > +> Shouldn't we do 4. before 2.? > > 4 is done via vfs_write_suspend() function, which synchronize file > system once again. > OK. Does vfs_write_suspend mark the file system as clean again, too? I mean: What if bewteen step 3 and 4 someone makes the file system dirty? > As I said gjournal is below file system layer. It receives I/O requests > only and cannot say which one is related to growing file, which has > metadata inside, etc. > Yeah, below -- as u said in the email, I responded to... I thought, the file system code supports gjournal somehow in that point, too... And I was too lazy to look into the patch u provided... Might it be possible to get some more optional assistance by the file system? Maybe we could provide a /dev/ad0.gjournal and a /dev/ad0.fs-data, which would break the GEOM concept a little bit...? *sigh* Maybe the file system code could use negative block numbers or high block numbers (somehow like a hint: U can write it right to the file system without any worries)? Of course those quick-write-through blocks should not be subject to a remove operation in the currently active journal area (I mean just in case, the system crashes while that journal is still active)... *sigh* I hope, I do not disturb the list too much... But I still like the BIO_FLUSH... -Arne --- Arne slow sometimes... :-) __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com