From owner-cvs-src@FreeBSD.ORG  Sat Dec 27 17:56:49 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6A4C016A4CE
	for <cvs-src@FreeBSD.org>; Sat, 27 Dec 2003 17:56:49 -0800 (PST)
Received: from relay.pair.com (relay.pair.com [209.68.1.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9017043D45
	for <cvs-src@FreeBSD.org>; Sat, 27 Dec 2003 17:56:46 -0800 (PST)
	(envelope-from silby@silby.com)
Received: (qmail 79901 invoked from network); 28 Dec 2003 01:56:45 -0000
Received: from niwun.pair.com (HELO localhost) (209.68.2.70)
  by relay.pair.com with SMTP; 28 Dec 2003 01:56:45 -0000
X-pair-Authenticated: 209.68.2.70
Date: Sat, 27 Dec 2003 19:56:44 -0600 (CST)
From: Mike Silbersack <silby@silby.com>
To: Sam Leffler <sam@errno.com>
In-Reply-To: <200312271751.01178.sam@errno.com>
Message-ID: <20031227195427.Y46996@odysseus.silby.com>
References: <200312280143.hBS1hMwD065855@repoman.freebsd.org>
 <200312271751.01178.sam@errno.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha vm_machdep.csrc/sys/amd64/amd64
 vm_machdep.c src/sys/i386/i386 vm_machdep.c src/sys/ia64/ia64     
 vm_machdep.c src/sys/powerpc/powerpc vm_machdep.c    
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2003 01:56:49 -0000


On Sat, 27 Dec 2003, Sam Leffler wrote:

> >   Move the declaration of sfbufspeak and sfbufsused to mbuf.h,
> >   and use imax instead of max, as sfbufspeak and sfbufsused
> >   are signed.
> >
>
> These have nothing to do with mbufs; why move the decls to mbuf.h?
>
> 	Sam

Because I can't think of anywhere else sendfile related values would fit.
So far our only use of sfbufs in the system is to attach them to mbufs and
send them out via sockets.  FWIW, I'm about to overload mbstat with some
sendfile statistics as well, because I can't think of another place that
they would fit well.  I'm open to ideas, as long as they don't involve
creating yet another header file.

Mike "Silby" Silbersack