Date: Sat, 27 Dec 2003 19:56:44 -0600 (CST) From: Mike Silbersack <silby@silby.com> To: Sam Leffler <sam@errno.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha vm_machdep.csrc/sys/amd64/amd64 vm_machdep.c src/sys/i386/i386 vm_machdep.c src/sys/ia64/ia64 vm_machdep.c src/sys/powerpc/powerpc vm_machdep.c Message-ID: <20031227195427.Y46996@odysseus.silby.com> In-Reply-To: <200312271751.01178.sam@errno.com> References: <200312280143.hBS1hMwD065855@repoman.freebsd.org> <200312271751.01178.sam@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 27 Dec 2003, Sam Leffler wrote: > > Move the declaration of sfbufspeak and sfbufsused to mbuf.h, > > and use imax instead of max, as sfbufspeak and sfbufsused > > are signed. > > > > These have nothing to do with mbufs; why move the decls to mbuf.h? > > Sam Because I can't think of anywhere else sendfile related values would fit. So far our only use of sfbufs in the system is to attach them to mbufs and send them out via sockets. FWIW, I'm about to overload mbstat with some sendfile statistics as well, because I can't think of another place that they would fit well. I'm open to ideas, as long as they don't involve creating yet another header file. Mike "Silby" Silbersack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031227195427.Y46996>