From owner-svn-src-head@freebsd.org Wed Mar 23 01:32:01 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69F08A9287A; Wed, 23 Mar 2016 01:32:01 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bbn0101.outbound.protection.outlook.com [157.56.111.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B314D1CFC; Wed, 23 Mar 2016 01:31:59 +0000 (UTC) (envelope-from jtl@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-junipernetworks-onmicrosoft-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gvGxzxEhoHHHRxiU5mHk3jzItK92a4A7xT154v7Zsn4=; b=P0NTYAqcCOD+sr1arhm7T4Sg9SQL8d2I78KYRusxfnyI1ew4TSnuPYM5lAS7gbzLFKuN+zjwPMJCBX4trT+xCBEmb9ZAysF/+fG+2rGlxhTlV3e5duRDU43tZMy68YvqsXW+b4RYL6g2w2fruyUfD+L1tAV8FVNGDGZTqz7uDUo= Received: from BY2PR05CA034.namprd05.prod.outlook.com (10.141.250.24) by BLUPR0501MB2116.namprd05.prod.outlook.com (10.164.23.146) with Microsoft SMTP Server (TLS) id 15.1.434.16; Wed, 23 Mar 2016 01:31:52 +0000 Received: from BN1BFFO11FD006.protection.gbl (2a01:111:f400:7c10::1:145) by BY2PR05CA034.outlook.office365.com (2a01:111:e400:2c5f::24) with Microsoft SMTP Server (TLS) id 15.1.443.12 via Frontend Transport; Wed, 23 Mar 2016 01:31:52 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=freebsd.org; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=freebsd.org; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning freebsd.org discourages use of 66.129.239.19 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.19) by BN1BFFO11FD006.mail.protection.outlook.com (10.58.144.69) with Microsoft SMTP Server (TLS) id 15.1.443.6 via Frontend Transport; Wed, 23 Mar 2016 01:31:52 +0000 Received: from magenta.juniper.net (172.17.27.123) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 22 Mar 2016 18:31:47 -0700 Received: from [172.29.38.114] ([172.29.38.114]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id u2N1VjA49502; Tue, 22 Mar 2016 18:31:46 -0700 (PDT) (envelope-from jtl@freebsd.org) User-Agent: Microsoft-MacOutlook/0.0.0.160212 Date: Tue, 22 Mar 2016 21:31:45 -0400 Subject: Re: svn commit: r297193 - head/sys/netinet From: "Jonathan T. Looney" Sender: Jonathan Looney To: "cem@FreeBSD.org" CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: <5E92CFCC-DA54-4379-87FD-6EB183E6AFAB@juniper.net> Thread-Topic: svn commit: r297193 - head/sys/netinet References: <201603221555.u2MFtHgt068663@repo.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:66.129.239.19; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(189002)(199003)(377454003)(24454002)(81166005)(76176999)(82746002)(83506001)(2950100001)(87936001)(189998001)(110136002)(77096005)(6806005)(4001350100001)(1096002)(230700001)(1220700001)(11100500001)(19580405001)(19580395003)(15975445007)(47776003)(586003)(86362001)(50466002)(450100001)(5820100001)(50986999)(2906002)(2501003)(16796002)(4326007)(23676002)(2351001)(105596002)(83716003)(92566002)(54356999)(36756003)(33656002)(106466001)(42262002)(104396002); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR0501MB2116; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD006; 1:TmEf9/wnd39IXmOnit/61Zkg8+Z03BikPiCCXJKHPE7K0RtAozvAYtch8Uaq02QiPRhn7qMmwtJv8iyxfkt1RaXJLqvumxKjpfPEcp6eehq1vXdPtdDFlH7CPxT7pPHP/l1uD9aS0dni2wCFqvUi5AllfBiNVmiyDiohcvWNLStEsu8ANxxPhFXtfiuUJN7fjyQRE8AMGsspuVx4EgeUNw22rgycVvzDtsqMpS1+Yhczfreh5nqz0gxcX5lKlymOlzciKKoIcexjIxDwevQeBVTuQ8cfbEW8ukEnxd+sLeCEk3EoPeL6+29xEUp5qhviLagKFSMd+khxMGovsYNDWRL2LMQkLbF4VYd84kpr/VRYxMt8mhmvlKvS7WsruaFPa4on5UERRrf5I7PhLQ7kIx0OS4zbH/0vWt81MUJi589+8D9WhHX0kB5ra+yvUnQvehavJgE2Bw9DPn8RnE9n1M5K8yxOvqM1igTsvssVPYH/gq1bnehuYszelSnRctry X-MS-Office365-Filtering-Correlation-Id: 46788032-8042-49c3-1226-08d352bae97f X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2116; 2:8SnaFn1T0LX6ZnIy4VYF6cgE0oCbcjsvZrsEpsZqilNgZElwp2HfJYRjQCecduuOw6X/2qOPi0J0vt7N0dVYVGrCVDT0FmEf/QxQatn26dDb9X0G0HeEQr2DV2zksb8TDY6UKCQpALM0P8f9xml88l4aE5FCOjO5AhAnU+PdcwPooG1Iym5r+FkDbpG3sMeL; 3:Lv6eHLRrgXVZhokc34quqmLK0e6Xn2bjzhii4rvkD9NSJJFum63sHEbpICR/PcLe4YnhjJ8lJqJxU16k9ZPePyrEUZPIJBvl415SmKoKTWr6nDFbafPpdUwaEcfsjs0WfRfpJtTQxOLc2lZliFHdUI6xLCziMtQJbGWDiqPDRdCnmzdtFKoe5dI5GGodyHrcqM29D+mSy2w1W/kBozATYr6qRCoyzc9awZ5xfUUaYLc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0501MB2116; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2116; 25:Dz8lcWbvkxPche2vnPs0bY4T2/wKtkmH1NY1iKEeV9s/8bbWOfVp7Bqw+cq+HhjaL8fB1RVd5VoRYQ7jyS6pvqCeXrnX/FCMQWhAxXopfzRgpe5sEPguzBggT0z/hkUKf7MoPN3w6myt4py0S5OOcLgA9HDhdkY3FrQSC/qU4NT63VbXeDPLIkIjVF/ra/h/lw2TiYLw6h916KdNrZtBQaNDkdIh58/j2rFXZJQTcoVQkGwQy2h72reV4g6ebzjg+XKPH6s31uRpgPX9KqhQPVBXS0c2RUgMGnztBDOm9sLdkFxBX+A33Waky8hVYeAGbgQMaGfzCnL6vZjCnxq0tOtgpwqA7r7IbaqIRNj6B8Hoi2068bz/Gk1Hv+ccSU0/VmTcFKxkvYNS2fK3gIgRuQAVaKjnB+AIVe8dj32pl/po86XFhxfDWFh4xJEphLWtGOiyVHuS8dPg6mW01ZQJXxMxRHP231mcW6AcNPioA6TnGy+V4KruhL+379XpmnUYPLWesYHuk5gVdyHx3gj4I3C2SgaJReT0jhOCClF2P4K/MEMt9rcQgMyWGnHhx+zeYWNszvJsvGDEVk0jmJpi0A== X-JNPR-Received-From: outside X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2116; 20:3Oq2/sez2Ij3qBXzA98eg8Tad/ECjVzFrvKH9WIsVz69NB6MLipJ/iAHeVu8gcdojEN7l2bnbIfgMpM4sBlxrzj9A24c45A7q5rB/6ubnXHhWKPuH7P4SGh1InxILvGSRaq/bAHyXbkTIyw0Haq1JAO1btS0zMYyX39srzHbtorTL/9jQJGp1agw6e8TpEKL2I4wTbN4kR3FzJiAVo59fLgOFINgKXlx1z3KwcouPJrbOiqy85TYg78fQZFNo4xNh0zRy8dKfzhUCnm9n1iPj3GEYzIal2QxxYOQatz9u4NcJg5kXHlN2ghStVgICqb7AbxckI58YnhRQuHmrk09zUB/v86Ota6vL2w55DBoiLRGv7bvUPcN/bYN4d9rMkns23SPWC7NIBNofOAFVB0uIufOONba9Vr8agcDe3bD47YRcFupyk8zDVSjsTS/QcVCHbds7Hzc5ojiaKmfSGaGzPbJuPFi/K9e+Z7e9ZUXXVuGb9DGK4D9zEuxxLH/099E X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(13018025)(13015025)(13024025)(13017025)(13023025)(5005006)(10201501046)(3002001); SRVR:BLUPR0501MB2116; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0501MB2116; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2116; 4:FOYJkafMj4eYBdYL4+d4rTXwWJbheuhZ6yPcD0SToWbb+BIkW2pDyHsn0RXkp3saqBEQsKFqJEhr36oWcvOp7JAE1NdyfyetMzll1aN8Pr7XoDf6HrPBnTph5VXCDCcSPOPd6zLtK4nqlhbva8gmUCuo1O81HqaOfejIRGXYLTnWPoMrcWGK2D0hV9CEdIknN/im39wTxTw/loEjF8HlctoXd6Bs7tu9bCRjZp60VFNBLVbtUs+lHMxv8qWgmF7b9uldiZxpBoP9NDGFm/Co2CIh1WFvsAZHYMRdAbjURLijW95XHqdS8sR4KjmS9hBJN196A29tF4vxskhIrDmyJg+SYUU5S2vj7RWP73I0bC/pyrtHAvOuBvWfrei2uHD6c6g7M9UqEJDukFtFM1CD9HqaztRkPDgvUvBv8/J1zopIoDlodqQ9ch+9Oq/TGDMxqQtEA2fRn89ybMga4cuB2w== X-Forefront-PRVS: 08902E536D X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA1MDFNQjIxMTY7MjM6aEpPbHBob3NQSk5iaEtlS3kvU2JTREFD?= =?utf-8?B?eGluQVBnbGJwSHIwVm9MNHFyRktUUWhDLzdXdHhyQSt4L2Yyalc4YnN1UUpu?= =?utf-8?B?ZENhaUMzVFJYVk4vRXZ1bEhsRjNoU1gxTm93WlYxY0pob1VldThOaUQybUVF?= =?utf-8?B?RjJ5L08ySDdkYlFEdUhEelpkNFhwTzl4emN5VG1JcHZMZzA2TjJRMEtNRk5n?= =?utf-8?B?ZkQxYVRxYnFma01YNFBiVFkrU3k2dEZyWGJWS2ZCdkV2N2t3MWY0YlFCOUVr?= =?utf-8?B?aUxnYkZPU0pqMlFqQ1N2NlQ4dkRObFM0MnJYdW5naTlFcGZVR002TDBBSktv?= =?utf-8?B?bGRTRzFrRnNSc0NGdG9qRzE3ZkkvUldyWWJVeFo4ajdOSjh6bE9MNTdBd0ty?= =?utf-8?B?MVdPcG9aaFp1MjEySForY2dpc3UwbUt5ZmZreGdDTzJIT2hIUmFnSjRTNmdn?= =?utf-8?B?b3N1NVpuMmExbysyVWV6T1RTdERUai9vYitWWnBFRTBpWWU0N29DcVp0MlMr?= =?utf-8?B?UlFpbzVWOGhjUURIMXc5Qzk2elZUOGpjWjNmM0ozMVBrL2RTQ1dBcHR4bGY5?= =?utf-8?B?cGpYdVJxdGlnMUVGNVM2czFybkNnUjR0dnFFcEROK2FZWkpOUmJyeEJsc1Mv?= =?utf-8?B?eldUZmg4OWlod2J4K0tleEV2SnM3L1N5MEEzNWhBVER4dGJId0lqVUdkanFx?= =?utf-8?B?c1k5Z09PREpMekNjTXA4UUhaYldrUTBDNDBYaStvcWQybkJ6TzZVeUJCbzk5?= =?utf-8?B?SlF5TUJlK2EzZjAySXhIUnRtdVBjODhPd1AwcFpSb0NQWitnTDNJd05xOTNi?= =?utf-8?B?MUNkZ25xcjZqRXV1enZ1RDNjVWRkSER0UGRWTjE5eVNiTSt5MzZVVW5lUDUr?= =?utf-8?B?clVBKzNQU0NxeEt2Y0E4Y2pPOEo5ZWprYXZNc3dWSHAxVTBoWTR1eHFrdkRo?= =?utf-8?B?NUJxMnI4Vmc0dUVKaG9hdlRXVFMxTzhVd01neHoxU1B5cXVZdmJUc1p4SnEv?= =?utf-8?B?aXU1ajZUOWE0dUcvRStoYS94RGdZbUdiMHpwcUREOXZuekVBZ1ZpMUxSTFhV?= =?utf-8?B?NnVRdVlad25YOFF4RTlVT2FCZTJmcGdVWFRTdUVWcmFVK3RiUXFKeE9URGt4?= =?utf-8?B?dFM4d0dkREFvejZwaWxVdy84QmZXTVJOaGVrR2FJVitTNm0xTE5uNkphRU5Y?= =?utf-8?B?U3NEVlM5UDIzdmZhMkN0cytNejJEMkwwRUk0aHVoazFJYUxlWFppNW9FQllv?= =?utf-8?B?eVcxbEpuTU5WS01MRDE3SXFlL1d4REVVQ3hVbVFoQUp2SC9CMWVBLzBiUVlv?= =?utf-8?B?WGxHQlhDRmduSG5ON3o5OE5wem5HT2xKa2t4aXJFeGNvaVBocWFDY1RVVWZC?= =?utf-8?B?eWVkQ3h1M2I3U0w1QnVIbjkySG1ZQS9LN2ZIUC9qV3hhd3J4N1RtT1NncG05?= =?utf-8?B?bnlXdFRCYVRXeDF1VEZEUzF3WU1CdTl3UVFnWTd5djR2VVA2WEJOM1R6MXNX?= =?utf-8?B?M2cweU1UMlFTR3RsNENrZ3Q1NTRyVytHZjJiQmRRVjlUdWI0by9qSGdycVNP?= =?utf-8?B?RHNzcDA3NjA4ZldLMnlUWitta1FGcW1PNXNEVmhadElybUpLaWZqN1hZb2ty?= =?utf-8?Q?4=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2116; 5:YwR3qkC/GtRbI8LGylQuQ9sDVUcvVPRAkAbBFhTiOB9SRj7uIITitB1q4sHo6Eul5X6O2IHff/FY7tMvKliJenwA0xf25ZLOIQiA5mXf0OF8yS8OepXwysKYLAPCK6PZ0ceuFzJ2GnAkz+e5+h56Eg==; 24:CWt+cyRgCCF1kJG3CbbUUY/LoSsFcjrzjI5t/9wGWLtdraWjDZSRHCvAJpZW/fFdE5Mkse9uhV5botzi6EZ3rGzgpeOos7qTriB/klwlmuo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2016 01:31:52.0597 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0501MB2116 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 01:32:01 -0000 On 3/22/16, 7:59 PM, "Conrad Meyer" wrote: >On Tue, Mar 22, 2016 at 8:55 AM, Jonathan T. Looney wrote: >> Author: jtl >> Date: Tue Mar 22 15:55:17 2016 >> New Revision: 297193 >> URL: https://svnweb.freebsd.org/changeset/base/297193 >> >> ... >> >> MFC after: 2 weeks > >This change seems like it would be ineligible for a MFC due to >changing the ABI of struct tcpopt. Conrad, Thanks for the second set of eyes! However, I don't think struct tcpopt is part of the ABI. As far as I know, it is only used for communication within the kernel. Do you have an example of where it is used as part of the ABI? In the end, I don't really care. I had just planned to do the MFC to be a "good citizen". Jonathan