Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Mar 2016 21:31:45 -0400
From:      "Jonathan T. Looney" <jtl@freebsd.org>
To:        "cem@FreeBSD.org" <cem@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r297193 - head/sys/netinet
Message-ID:  <5E92CFCC-DA54-4379-87FD-6EB183E6AFAB@juniper.net>
In-Reply-To: <CAG6CVpXrxPN4RCo%2B%2BPqnZ1=iHi=RhWN26CYU7Exx8w7HP9VkTQ@mail.gmail.com>
References:  <201603221555.u2MFtHgt068663@repo.freebsd.org> <CAG6CVpXrxPN4RCo%2B%2BPqnZ1=iHi=RhWN26CYU7Exx8w7HP9VkTQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 3/22/16, 7:59 PM, "Conrad Meyer" <cem@FreeBSD.org> wrote:

>On Tue, Mar 22, 2016 at 8:55 AM, Jonathan T. Looney <jtl@freebsd.org> wrote:
>> Author: jtl
>> Date: Tue Mar 22 15:55:17 2016
>> New Revision: 297193
>> URL: https://svnweb.freebsd.org/changeset/base/297193
>>
>> ...
>>
>>   MFC after:    2 weeks
>
>This change seems like it would be ineligible for a MFC due to
>changing the ABI of struct tcpopt.

Conrad,

Thanks for the second set of eyes!

However, I don't think struct tcpopt is part of the ABI. As far as I know, it is only used for communication within the kernel. Do you have an example of where it is used as part of the ABI?

In the end, I don't really care. I had just planned to do the MFC to be a "good citizen".

Jonathan




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5E92CFCC-DA54-4379-87FD-6EB183E6AFAB>