From owner-freebsd-bugs  Thu Apr 26  3:10:10 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id A558037B423
	for <freebsd-bugs@hub.freebsd.org>; Thu, 26 Apr 2001 03:10:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f3QAA3213897;
	Thu, 26 Apr 2001 03:10:03 -0700 (PDT)
	(envelope-from gnats)
Date: Thu, 26 Apr 2001 03:10:03 -0700 (PDT)
Message-Id: <200104261010.f3QAA3213897@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: marck@rinet.ru
Subject: gnu/26771: cvs checkout bug with existing val-tags and readonlyfs
Reply-To: marck@rinet.ru
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

The following reply was made to PR gnu/26771; it has been noted by GNATS.

From: marck@rinet.ru
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: gnu/26771: cvs checkout bug with existing val-tags and readonlyfs
Date: Sun, 22 Apr 2001 19:04:17 +0400 (MSD)

 >Number:         26771
 >Category:       gnu
 >Synopsis:       cvs checkout bug with existing val-tags and readonlyfs
 >Confidential:   no
 >Severity:       serious
 >Priority:       high
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Sun Apr 22 08:10:03 PDT 2001
 >Closed-Date:
 >Last-Modified:
 >Originator:     Dmitry Morozovsky <marck@rinet.ru>
 >Release:        Various
 >Organization:
 Cronyx Plus LLC (RiNet ISP)
 >Environment:
 	cvs versions at least 1.10, 1.11
 
 >Description:
 
 When:
 
 - repository is readonly, and
 - there is CVSROOT/val-tags file, and
 - you try to check out tree with valid tag, and
 - this tag is not exist in CVSROOT/val-tags file
 
 cvs exits with an error such as:
 
 [checkout aborted]: cannot write /.../CVSROOT/val-tags: Read-only file system
 
 
 >How-To-Repeat:
 
 See description.
 
 
 >Fix:
 
 Just do not try to modify val-tags when readonlyfs is set:
                                                           
 Index: src/contrib/cvs/src/tag.c
 ===================================================================
 RCS file: /pub/FreeBSD/ncvs/src/contrib/cvs/src/tag.c,v
 retrieving revision 1.1.1.6.2.1
 diff -u -r1.1.1.6.2.1 tag.c
 --- src/contrib/cvs/src/tag.c   2000/10/31 09:37:58     1.1.1.6.2.1
 +++ src/contrib/cvs/src/tag.c   2001/04/22 14:15:48                     
 @@ -868,7 +868,8 @@
         /* The tags is valid but not mentioned in val-tags.  Add it.  */
         datum value;
 
 -       if (noexec)
 +       /* Do not try to add tags if our repository is read-only */
 +       if (noexec || readonlyfs)
         {
             if (db != NULL)
                 dbm_close (db);
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 
 To Unsubscribe: send mail to majordomo@FreeBSD.org
 with "unsubscribe freebsd-bugs" in the body of the message

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message