Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 08 Sep 2020 20:02:28 +0000
From:      bugzilla-noreply@freebsd.org
To:        toolchain@FreeBSD.org
Subject:   [Bug 230888] Missing 64 bit atomic functions for i386 (libatomic)
Message-ID:  <bug-230888-29464-jWDMDofDfl@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-230888-29464@https.bugs.freebsd.org/bugzilla/>
References:  <bug-230888-29464@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230888

--- Comment #30 from commit-hook@FreeBSD.org ---
A commit references this bug:

Author: dim
Date: Tue Sep  8 20:02:09 UTC 2020
New revision: 365471
URL: https://svnweb.freebsd.org/changeset/base/365471

Log:
  MFC r364753:

  Add atomic and bswap functions to libcompiler_rt

  There have been several mentions on our mailing lists about missing
  atomic functions in our system libraries (e.g. __atomic_load_8 and
  friends), and recently I saw __bswapdi2 and __bswapsi2 mentioned too.

  To address this, add implementations for the functions from compiler-rt
  to the system compiler support libraries, e.g. libcompiler_rt.a and and
  libgcc_s.so.

  This also needs a small fixup in compiler-rt's atomic.c, to ensure that
  32-bit mips can build correctly.

  Bump __FreeBSD_version to make it easier for port maintainers to detect
  when these functions were added.

  PR:           230888
  Differential Revision: https://reviews.freebsd.org/D26159

  MFC r364782:

  After r364753, there should be no need to suppress -Watomic-alignment
  warnings anymore for compiler-rt's atomic.c. This occurred because the
  IS_LOCK_FREE_8 macro was not correctly defined to 0 for mips, and this
  caused the compiler to emit a runtime call to __atomic_is_lock_free(),
  and that triggers the warning.

Changes:
_U  stable/11/
  stable/11/contrib/llvm-project/compiler-rt/lib/builtins/atomic.c
  stable/11/lib/libcompiler_rt/Makefile.inc
  stable/11/sys/sys/param.h
_U  stable/12/
  stable/12/contrib/llvm-project/compiler-rt/lib/builtins/atomic.c
  stable/12/lib/libcompiler_rt/Makefile.inc
  stable/12/sys/sys/param.h

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230888-29464-jWDMDofDfl>