From owner-cvs-all Tue Jan 12 05:36:33 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA19403 for cvs-all-outgoing; Tue, 12 Jan 1999 05:36:33 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.204.136.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA19395; Tue, 12 Jan 1999 05:36:30 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.1a/8.9.1) with ESMTP id OAA29906; Tue, 12 Jan 1999 14:35:51 +0100 (CET) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id OAA66578; Tue, 12 Jan 1999 14:35:51 +0100 (MET) Date: Tue, 12 Jan 1999 14:35:51 +0100 From: Eivind Eklund To: Luigi Rizzo Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_input.c Message-ID: <19990112143551.D65459@bitbox.follo.net> References: <199901121225.EAA12902@freefall.freebsd.org> <199901121117.MAA23744@labinfo.iet.unipi.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <199901121117.MAA23744@labinfo.iet.unipi.it>; from Luigi Rizzo on Tue, Jan 12, 1999 at 12:17:22PM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Tue, Jan 12, 1999 at 12:17:22PM +0100, Luigi Rizzo wrote: > > Modified files: > > sys/netinet ip_input.c > > Log: > > Add #ifdef's to avoid unused label warning in some cases. > > i wonder if it is preferable to clutter the code with #ifdef's or > tolerate the potential warnings. Unless good counter-arguments spring forward, -Werror is going in shortly, so tolerating the warnings is not an option. This is because people otherwise ignore their warnings, and this make it difficult to use the warnings to remove true bugs (of which I've found at least 3 during this round of commits). Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message