From owner-p4-projects@FreeBSD.ORG Mon Jun 8 20:43:51 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D7F931065678; Mon, 8 Jun 2009 20:43:50 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 905E41065670 for ; Mon, 8 Jun 2009 20:43:50 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 61FF68FC20 for ; Mon, 8 Jun 2009 20:43:50 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n58KhoG1016648 for ; Mon, 8 Jun 2009 20:43:50 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n58Khoa0016646 for perforce@freebsd.org; Mon, 8 Jun 2009 20:43:50 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Mon, 8 Jun 2009 20:43:50 GMT Message-Id: <200906082043.n58Khoa0016646@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 163829 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 20:43:52 -0000 http://perforce.freebsd.org/chv.cgi?CH=163829 Change 163829 by rwatson@rwatson_freebsd_capabilities on 2009/06/08 20:43:11 Allow fork(2) in sandboxes -- pdfork(2) should be preferred, but fork(2) isn't harmful. Affected files ... .. //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#19 edit .. //depot/projects/trustedbsd/capabilities/src/sys/kern/init_sysent.c#32 edit .. //depot/projects/trustedbsd/capabilities/src/sys/kern/syscalls.c#32 edit .. //depot/projects/trustedbsd/capabilities/src/sys/kern/systrace_args.c#32 edit .. //depot/projects/trustedbsd/capabilities/src/sys/sys/syscall.h#32 edit .. //depot/projects/trustedbsd/capabilities/src/sys/sys/syscall.mk#32 edit .. //depot/projects/trustedbsd/capabilities/src/sys/sys/sysproto.h#32 edit Differences ... ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#19 (text+ko) ==== @@ -38,7 +38,7 @@ ## - sys_exit(2), abort2(2) and close(2) are very important. ## - Sorted alphabetically, please keep it that way. ## -## $P4: //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#18 $ +## $P4: //depot/projects/trustedbsd/capabilities/src/sys/kern/capabilities.conf#19 $ ## ## @@ -191,6 +191,12 @@ flock ## +## Allow fork(2), even though it returns pids -- some applications seem to +## prefer this interface. +## +fork + +## ## Allow fpathconf(2), subject to capability rights. ## fpathconf ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/init_sysent.c#32 (text+ko) ==== @@ -30,7 +30,7 @@ struct sysent sysent[] = { { 0, (sy_call_t *)nosys, AUE_NULL, NULL, 0, 0, 0 }, /* 0 = syscall */ { AS(sys_exit_args), (sy_call_t *)sys_exit, AUE_EXIT, NULL, 0, 0, SYF_CAPENABLED }, /* 1 = exit */ - { 0, (sy_call_t *)fork, AUE_FORK, NULL, 0, 0, 0 }, /* 2 = fork */ + { 0, (sy_call_t *)fork, AUE_FORK, NULL, 0, 0, SYF_CAPENABLED }, /* 2 = fork */ { AS(read_args), (sy_call_t *)read, AUE_NULL, NULL, 0, 0, SYF_CAPENABLED }, /* 3 = read */ { AS(write_args), (sy_call_t *)write, AUE_NULL, NULL, 0, 0, SYF_CAPENABLED }, /* 4 = write */ { AS(open_args), (sy_call_t *)open, AUE_OPEN_RWTC, NULL, 0, 0, 0 }, /* 5 = open */ ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/syscalls.c#32 (text+ko) ==== ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/systrace_args.c#32 (text+ko) ==== ==== //depot/projects/trustedbsd/capabilities/src/sys/sys/syscall.h#32 (text+ko) ==== ==== //depot/projects/trustedbsd/capabilities/src/sys/sys/syscall.mk#32 (text+ko) ==== ==== //depot/projects/trustedbsd/capabilities/src/sys/sys/sysproto.h#32 (text+ko) ====