From owner-cvs-all Tue Dec 12 10:55:43 2000 From owner-cvs-all@FreeBSD.ORG Tue Dec 12 10:55:39 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id E8F9537B400; Tue, 12 Dec 2000 10:55:38 -0800 (PST) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eBCIpfE92510; Tue, 12 Dec 2000 10:51:41 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <3A367222.1EDB3221@cup.hp.com> Date: Tue, 12 Dec 2000 10:51:46 -0800 (PST) From: John Baldwin To: Marcel Moolenaar Subject: Re: cvs commit: src/sys/i386/include mutex.h Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 12-Dec-00 Marcel Moolenaar wrote: > John Baldwin wrote: >> >> > Modified files: >> > sys/i386/include mutex.h >> > Log: >> > Fix the assembly mutex macros to call the appropriate witness functions >> > if >> > the witness code is compiled in. Without this, the witness code doesn't >> > notice that sched_lock is released by fork_trampoline() and thus gets >> > all >> > confused about spin lock order later on. >> >> Similar work needs to be done on the alpha and ia64 as well. Right now >> fork_trampoline() is the only case this kicks in, but the light weight >> context >> switches will rely on this even more. > > I'll take a look at ia64. I'm already in the process of getting the port > back into shape (sort of)... It might be easier to just call the _mtx_enter() and _mtx_exit() functions than to go through the hassles of coding up calls to witness and mutex operations in complete asm. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message