From owner-svn-src-all@freebsd.org Mon Apr 9 14:04:25 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B66E0F82F97; Mon, 9 Apr 2018 14:04:25 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 551906EFD8; Mon, 9 Apr 2018 14:04:25 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 40KX9C6bdNzDhHq; Mon, 9 Apr 2018 14:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=daemonic.se; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received; s=20151023; t=1523282655; bh=n8t1Xcs5UktdCZjSdPMX8w2B xEeE4ymM4EPHNZnTGMU=; b=JpjRpcxB5N+iWdxKgxrSMhUojvvwtwvKgcl7QW6B 2Pc+7Uc/Zq/L1UvmsXrl73NRFUvDN5lei0cvmmG18hfm2H6uF8CJ/1oXaSumSy3t IeiBBZivOioWUu+OPlym/mHcEWuaLHoJEgO9FX4oCiWEW2XTi6cuek3grmeEw6rF 2XU= X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id iIRL8nS-L3xx; Mon, 9 Apr 2018 14:04:15 +0000 (UTC) Received: from garnet.daemonic.se (host-95-192-191-149.mobileonline.telia.com [95.192.191.149]) by mail.daemonic.se (Postfix) with ESMTPSA id 40KX9C0TntzDh2K; Mon, 9 Apr 2018 14:04:15 +0000 (UTC) Subject: Re: svn commit: r331880 - stable/11/etc To: rgrimes@freebsd.org, Kyle Evans Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-11@freebsd.org References: <201804021539.w32FdaID083096@pdx.rh.CN85.dnsmgr.net> From: Niclas Zeising Message-ID: <9cfe34fc-196a-df96-7eaf-036cc4c17bdd@daemonic.se> Date: Mon, 9 Apr 2018 16:04:14 +0200 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <201804021539.w32FdaID083096@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 14:04:25 -0000 On 04/02/18 17:39, Rodney W. Grimes wrote: >> Author: kevans >> Date: Mon Apr 2 15:28:48 2018 >> New Revision: 331880 >> URL: https://svnweb.freebsd.org/changeset/base/331880 >> >> Log: >> MFC r328331: Support configuring arbitrary limits(1) for any rc.conf daemon >> >> Usage is ${name}_limits, and the argument is any flags accepted by >> limits(1), such as `-n 100' (e.g. only allow 100 open files). >> >> Modified: >> stable/11/etc/rc.subr >> Directory Properties: >> stable/11/ (props changed) >> >> Modified: stable/11/etc/rc.subr >> ============================================================================== >> --- stable/11/etc/rc.subr Mon Apr 2 15:07:41 2018 (r331879) >> +++ stable/11/etc/rc.subr Mon Apr 2 15:28:48 2018 (r331880) >> @@ -773,6 +773,8 @@ check_startmsgs() >> # >> # ${name}_login_class n Login class to use, else "daemon". >> # >> +# ${name}_limits n limits(1) to apply to ${command}. >> +# > > Caution, limits(1) is in /usr/bin, this code can fail if used before > /usr is mounted. (Ie, our rc.initdiskless) is probably broken by > this change if a call is made to limits. > > Sorry for jumping on this so late. This is also an issue in CURRENT, and has been since at least 2016. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206291 Regards -- Niclas