From owner-svn-src-head@freebsd.org Thu Apr 19 15:19:09 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24491F83262 for ; Thu, 19 Apr 2018 15:19:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A7F576A93F for ; Thu, 19 Apr 2018 15:19:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x232.google.com with SMTP id f22-v6so4926805ioc.11 for ; Thu, 19 Apr 2018 08:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QydIaSkqj9SSw6im7p+JHRTBSBHiDnkrTSnkvAkHlCE=; b=G2lOK+cawLbXviSSw72+5yKhrKn9V7rv8X+nrTHPHBZuDGqjBMl5CvYlCcxaznOU+R R92QZffCyaX8FEvDkASFsL6m/kvp0JB85kqBCcer+pp+UBoWEF0/dE3vTuTP8DDdMik3 BmZbbdfXGhbi0JJWRPRVGlOsEB4aG/Kb8xjYrLgLYq5Eeo3xQPd0sGWg8XbFS66hUR4w Mhq7VUsqicplxMfua+GgTYnFUsLX84xNLYT+fYimj7xzVsN46/mIhfgViiMbBpcOGenX 7lOwp6pDPOy9wFIeuZblt5d1JTQSpwGvcNFnwpvuIK30r5LZqJ4oFfdDbnjmJPmj/Goy tpdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QydIaSkqj9SSw6im7p+JHRTBSBHiDnkrTSnkvAkHlCE=; b=KHuagmAATc7l6NULeUOqSqIp6ErfKbgFkk9ZSEZ9diSnjCdxXiliSBRD0zj2vrkBXX O3intWvAk1A4h2N3KOniHDEvFerAqmwZrwCWyzvxGua7kKBb66Zyr6khaYKVJMLmOqvO 0fpc0zFDD3xjz0JqjJyN38wNQEi3lcP0UGFxEOTJZHZoONLEQKx5EUQbjLqrlJsexuDD TOCBk1im7JQClwP/8StodLiAoaXapFp2m/y2nxvcVg1GkWHeKOZFhq6LDfz6wra9Vkyz xA77plSOe03pRRyyoe7qYR20/LMFoCx2XdAnGM9qidCnaA8JUSZCK1sTaT7fEg01h9HP AdCQ== X-Gm-Message-State: ALQs6tCEtGyMHXoyUn3E4Kg4iCH3tdCzQQHyLezHb5gud8X/4I+2Lohd W+YW5BfTaWBjhNJpY5qKct1r98SFi3bxgLUAnQrbYA== X-Google-Smtp-Source: AIpwx499v69YGtGAiq9RTvIBolVMK53KBFiweHWDknO1jg6CIZ41JaBukVIJprT6iHicM9/A85DkFSiAZiI3dw/7g54= X-Received: by 2002:a6b:12a3:: with SMTP id 35-v6mr6723962ios.168.1524151147850; Thu, 19 Apr 2018 08:19:07 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a604:0:0:0:0:0 with HTTP; Thu, 19 Apr 2018 08:19:07 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201804191502.w3JF2sgQ051472@repo.freebsd.org> <201804191516.w3JFG99V066371@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Thu, 19 Apr 2018 09:19:07 -0600 X-Google-Sender-Auth: At72CJ3unfTlalMv0LY77J8q6m8 Message-ID: Subject: Re: svn commit: r332773 - head/etc/rc.d To: Kyle Evans Cc: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 15:19:09 -0000 On Thu, Apr 19, 2018 at 9:17 AM, Kyle Evans wrote: > On Thu, Apr 19, 2018 at 10:16 AM, Rodney W. Grimes > wrote: > >> Author: kevans > >> Date: Thu Apr 19 15:02:53 2018 > >> New Revision: 332773 > >> URL: https://svnweb.freebsd.org/changeset/base/332773 > >> > >> Log: > >> Fix ddb rc script > >> > >> r288291 added a call to limits(1), which isn't available before > partitions > >> are mounted. This broke the ddb rc script, which does not provide its > own > >> start_cmd. > >> > >> Alleviate the situation here by providing a start_cmd. We still have > other > >> problems with diskless setups that need to be considered, but this is > a > >> start. > > > > Thanks, > > Also didn't cy identify a second one of these? > > Or am I confusing yet another issue? > > > > He identified a second early script that didn't specify start_cmd, but > it was a non-issue because it's invoked independently of rc.subr. > One would think that it shouldn't invoke limits at all if foo_limits= wasn't specified... Would make the feature much less invasive. Warner