From owner-p4-projects@FreeBSD.ORG Thu Dec 3 16:55:48 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F03AE1065679; Thu, 3 Dec 2009 16:55:47 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B48C51065672 for ; Thu, 3 Dec 2009 16:55:47 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id 3F5028FC17 for ; Thu, 3 Dec 2009 16:55:47 +0000 (UTC) Received: by bwz5 with SMTP id 5so1256758bwz.3 for ; Thu, 03 Dec 2009 08:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=woAQLGyR/IhWd3XtPQJ1seHlTwvNO6HITYQzoJBQ6no=; b=TOPFpwylcTJ8DGJ0v9ZilKZhU4tMw5QzXOJtuLJgTVC7Cxq+hJnYIFWzD8b/AAmCO7 iQF8/haWUNbWtOO2ocPo8y8LbDQK4M22/XjNOJpKyHbUhBDKd6Pgy5Ky1JHeaOm1jPpa N9Wp+cUlHNj80Jxknho9PeBEeaqf6OaDJWhgM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=SOMKpsO/pbYtYzYhgRKz6XsSwV1mSJkZt7BLiDCURdmvk2r7HoNSAhoudZS9cy0QQw 8KKq5inHeBJNHYZiNK/LznllcdMgQ4wT1QHJInIuhXadsq2zR5Ay5YVfnSKohSHLmHUQ Igl3XPkGD5NVpGUqi9ldlCjk3biPwLyVmSuaY= Received: by 10.204.7.197 with SMTP id e5mr1850175bke.184.1259857713803; Thu, 03 Dec 2009 08:28:33 -0800 (PST) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id 15sm812135fxm.2.2009.12.03.08.28.32 (version=SSLv3 cipher=RC4-MD5); Thu, 03 Dec 2009 08:28:33 -0800 (PST) Sender: Alexander Motin Message-ID: <4B17E72E.5010304@FreeBSD.org> Date: Thu, 03 Dec 2009 18:28:30 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20090901) MIME-Version: 1.0 To: Nathan Whitehorn References: <200912031546.nB3Fksxc047234@repoman.freebsd.org> <4B17DFEA.1020704@freebsd.org> In-Reply-To: <4B17DFEA.1020704@freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Perforce Change Reviews Subject: Re: PERFORCE change 171334 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2009 16:55:48 -0000 Nathan Whitehorn wrote: > Alexander Motin wrote: >> @@ -230,7 +229,7 @@ >> return EIO; >> } >> >> - request->dma = &ch->dma.slot[atadev->unit]; >> + request->dma = &ch->dma.slot[0]; >> >> if ((error = bus_dmamap_load(request->dma->data_tag, >> request->dma->data_map, request->data, request->bytecount, >> > I made an error in this part of the patch -- it should be request->unit, > not 0, here. Thanks for your work! It's not your fault, it's my change. It shouldn't be request->unit there, as only one DMA slot per channel allocated now. It is useless to allocate more, as rest of ata(4) infrastructure supports only one request at a time per channel. -- Alexander Motin