From owner-freebsd-stable@FreeBSD.ORG Fri Apr 27 20:28:35 2007 Return-Path: X-Original-To: freebsd-stable@FreeBSD.ORG Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8E51116A404; Fri, 27 Apr 2007 20:28:35 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 2253013C448; Fri, 27 Apr 2007 20:28:35 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l3RKSVl3029540; Fri, 27 Apr 2007 14:28:31 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46325CDE.2010904@samsco.org> Date: Fri, 27 Apr 2007 14:28:14 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Thomas Quinot References: <20070427150134.64D3713C448@mx1.freebsd.org> <20070427153218.GA9091@melamine.cuivre.fr.eu.org> <20070427174922.GA5655@zone3000.net> <46324CCF.7040109@samsco.org> <20070427193119.GA95165@melamine.cuivre.fr.eu.org> In-Reply-To: <20070427193119.GA95165@melamine.cuivre.fr.eu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Fri, 27 Apr 2007 14:28:32 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: freebsd-stable@FreeBSD.ORG, bug-followup@FreeBSD.ORG, linimon@FreeBSD.ORG, Nikolay Pavlov , "Ganbold.TS" , mjacob@FreeBSD.ORG Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2007 20:28:35 -0000 Thomas Quinot wrote: > * Scott Long, 2007-04-27 : > >> Oh hell, I know exactly what the problem is! The opcode for a >> TEST_UNIT_READY is 0x00. This is probably the command that is >> generating the CHECK_CONDITION. The test for saved_cmd is entirely >> bogus. > > Hmmmm. Looks like a very plausible culprit. Good catch Scott! > (I felt there had to be something wrong when I wrote that test, > incidentally, precisely because of TEST_UNIT_READY). > > Nikolay, Ganbold, (and others), here's another patch against 1.42.2.3, > please let me know if it works for you. > > Thomas. > > Index: atapi-cam.c > =================================================================== > RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v > retrieving revision 1.50 > diff -u -r1.50 atapi-cam.c > --- atapi-cam.c 14 Mar 2007 01:59:00 -0000 1.50 > +++ atapi-cam.c 27 Apr 2007 19:26:09 -0000 > @@ -729,7 +743,7 @@ > * issued a REQUEST SENSE automatically and that operation > * returned without error. > */ > - if (request->u.atapi.saved_cmd != 0 && request->error == 0) { > + if (request->u.atapi.sense.key != 0 && request->error == 0) { > bcopy (&request->u.atapi.sense, &csio->sense_data, sizeof(struct atapi_sense)); > csio->ccb_h.status |= CAM_AUTOSNS_VALID; > } Right, just make sure that this isn't filled with garbage before you send the command. If you're using ata_alloc_request(), and you're not recycling requests internally, then you should be fine. Scott