From owner-svn-src-head@freebsd.org Fri Jun 17 16:51:44 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D54A7A7819C; Fri, 17 Jun 2016 16:51:44 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id AFE6F1B5A; Fri, 17 Jun 2016 16:51:44 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id A965A1E55; Fri, 17 Jun 2016 16:51:44 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 67AE0DAF4; Fri, 17 Jun 2016 16:51:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id EPyeL1eDRzEj; Fri, 17 Jun 2016 16:51:42 +0000 (UTC) Subject: Re: svn commit: r301959 - head/sys/kern DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 8C62EDAEE To: Konstantin Belousov , Conrad Meyer References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <20160617061306.GS38613@kib.kiev.ua> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Fri, 17 Jun 2016 09:51:45 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160617061306.GS38613@kib.kiev.ua> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Jt34htBudipOAbaTOakPrNd9fq6xiSCE6" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 16:51:44 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jt34htBudipOAbaTOakPrNd9fq6xiSCE6 Content-Type: multipart/mixed; boundary="HObBJ5hGTFws0doCBSAtRQaJrNbb98SSU" From: Bryan Drewery To: Konstantin Belousov , Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r301959 - head/sys/kern References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <20160617061306.GS38613@kib.kiev.ua> In-Reply-To: <20160617061306.GS38613@kib.kiev.ua> --HObBJ5hGTFws0doCBSAtRQaJrNbb98SSU Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/16/2016 11:13 PM, Konstantin Belousov wrote: > On Thu, Jun 16, 2016 at 10:17:19AM -0700, Conrad Meyer wrote: >> style(9) nit: /* FALLTHROUGH */ >=20 > FALLTHROUGH is only applicable when there are executable statements for= > both cases, and first sequence of statements does not end in break. > Look at the switch() example right after the FALLTHROUGH requirement > in the style(9), which shows case '?'. >=20 Yes the example shows code in both cases, but the text about it is more strict "Elements in a switch statement that cascade should have a FALLTHROUGH comment." --=20 Regards, Bryan Drewery --HObBJ5hGTFws0doCBSAtRQaJrNbb98SSU-- --Jt34htBudipOAbaTOakPrNd9fq6xiSCE6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXZCqhAAoJEDXXcbtuRpfPsC0H/jOWJXEkMMI689nbH+iWARaj MEv9UVa3KIo7XH1lnWJnUiQ1np/ihKCwMI/7q/aZbfwBkuT7DWu25Beaow6lE6ii 2Cz0gCLYTq366v7mlhEpE60M8YfG3D6k+AcR2vy7iTtbYDNvFeMCBi+2CqzvP4c6 UGGanycqUJZSCdQ7lkcXp45QDoOIsmvXCagHJHevnBB1Nk62xl/EA82jpW55x4PG MYiWqY/DyilInItofqpNX4/7KsxxHx8W+wbhFu+1GIVxwsErHuJPRQeL0VCsJ4LR Zet+LJHbUQ33m9UsYBzo0ArxmxitnldRn70EnSWaUyetgAXMDOpGTqn/8FeQAOg= =0H0+ -----END PGP SIGNATURE----- --Jt34htBudipOAbaTOakPrNd9fq6xiSCE6--