Date: Mon, 19 Dec 2016 12:37:27 -0800 From: Ravi Pokala <rpokala@mac.com> To: Ian Lepore <ian@freebsd.org>, Warner Losh <imp@bsdimp.com> Cc: Sepherosa Ziehau <sepherosa@gmail.com>, Dimitry Andric <dim@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r310171 - head/sys/sys Message-ID: <F65A3D59-6FCD-4EEC-B2D2-40DB682B716D@panasas.com> In-Reply-To: <1482175209.48539.9.camel@freebsd.org> References: <201612161949.uBGJnMol059217@repo.freebsd.org> <CAMOc5cw8cBUN5UZjcRJ-vM5WE0vmD2AGDZ-raKTraFz7LBR2hg@mail.gmail.com> <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> <CANCZdfoN_NNsU2bW2mvLifSCoNhYj-XNvNYLosMsbmnbG9JfYQ@mail.gmail.com> <1482175209.48539.9.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Ian Lepore <ian@freebsd.org> > Date: 2016-12-19, Monday at 11:20 > To: Warner Losh <imp@bsdimp.com>, Ravi Pokala <rpokala@mac.com> > Cc: Sepherosa Ziehau <sepherosa@gmail.com>, Dimitry Andric <dim@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> > Subject: Re: svn commit: r310171 - head/sys/sys > > On Mon, 2016-12-19 at 11:58 -0700, Warner Losh wrote: >> >> ... >> >> Are there other precedence for avoiding the SCN macros in the tree as >> well, or is this new art? >> >> Warner > > There was another commit recently the fixed the same kind of scanf > error by making the variable fit the scanf type (changing uint64_t to > an explicit long long unsigned, iirc). I don't know if that alone > counts as a precedent, but IMO it's a more palatible fix than the > SCN/PRI ugliness. With all apologies to Churchill, SCN/PRI are the worst way to address this in a machine-independent way, except for all the other ways that have been tried from time to time. :-P -Ravi (rpokala@) > -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F65A3D59-6FCD-4EEC-B2D2-40DB682B716D>