From nobody Tue Jan 30 05:39:42 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TPDWf5kTZz58L3K for ; Tue, 30 Jan 2024 05:39:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TPDWf1nRsz4Wjx for ; Tue, 30 Jan 2024 05:39:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706593182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R4R8vll8ofolEKUr+Q1UugRMtQ57q08y5AKjXnp6lzY=; b=uTYkqp0I132K8pTqJCLzzgN0W+hwKBEOLJWzsnTkqDJr7+80wp5e9R3ORk4lTWxL0/WjFf KmqjWvB7Ao16Si1CPg1d9WyKWolc0z9Y3x+RcQbEAFchCDBt+AI/ReA644gam0RBztseCB vZZ6IF51cA99olEQV6X+8QqlUDyxc9n3E+YMPgy0WmWsnMPMo6My7OqNorNCrZykvPbxCB Sf5ogVAY9oS6P9G1BWdNkmuIf7F8aP+YmIzLznQTFd5D/vThjLL/dcxPkaEs4Yco3E3Btf 7G0bxLpZxYF91F7YUrTYKkavfgujTWXT/OwZkRkU7Nk6SzuonhrKC7zewPuKFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706593182; a=rsa-sha256; cv=none; b=XUfGL8kkKI2Ip2CCG42q4m9FeARaE9v5QijpHqwYKC76IGqE8YQUTN8kNkQOUUZJihXMsq V4aZTuUDX2lpXQOj0afQQpNdSM5RpDr2lyvXKTG4sPNzT5Jeo68YmRgEQH1XMtyYFb8N9w vbNOmbtclTiQBo3p6fCmH2pP5TQaXdYQmPM+KSiSSYw9WtWOzRsBLpyvgGw9h14XTA2maM ET4gD69ZXnuODjETJkx1hVBXqHAys/isB/zRu9BwMv3DY4tZQf3pYr0m6f9iRqh65J7R4E okaD9UmqgDB8Sq2nKCY6y055ZVVMpAP6QDGuClEyOcfufmrYMY5Sr+EyNtfH8A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TPDWf0pQ5zN60 for ; Tue, 30 Jan 2024 05:39:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40U5dgCX062268 for ; Tue, 30 Jan 2024 05:39:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40U5dgoV062266 for net@FreeBSD.org; Tue, 30 Jan 2024 05:39:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 276392] if_wg: Fix noise_remote_alloc() to acquire 'l_identity_lock' lock Date: Tue, 30 Jan 2024 05:39:42 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13? mfc-stable12- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276392 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dce2d249b207045f27ec03719997168c92= d0f6104 commit ce2d249b207045f27ec03719997168c92d0f6104 Author: Aaron LI AuthorDate: 2024-01-17 23:29:23 +0000 Commit: Kyle Evans CommitDate: 2024-01-30 05:37:57 +0000 if_wg: fix access to noise_local->l_has_identity and l_private These members are protected by the identity lock, so rlock it in noise_remote_alloc() and then assert that we have it held to some extent in noise_precompute_ss(). PR: 276392 (cherry picked from commit 7a4d1d1df0b2e369adcb32aea9ef8c180f885751) sys/dev/wg/wg_noise.c | 4 ++++ 1 file changed, 4 insertions(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=