From owner-cvs-all Tue Nov 27 9:20: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 48D8937B416; Tue, 27 Nov 2001 09:20:05 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id fARHK4768451; Tue, 27 Nov 2001 09:20:04 -0800 (PST) (envelope-from obrien) Date: Tue, 27 Nov 2001 09:20:04 -0800 From: "David O'Brien" To: Ruslan Ermilov Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/libpam/libpam pam_item.c Message-ID: <20011127092004.A68382@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200111271535.fARFZiN39835@freefall.freebsd.org> <20011127174709.J67032@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011127174709.J67032@sunbay.com>; from ru@FreeBSD.org on Tue, Nov 27, 2001 at 05:47:09PM +0200 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Nov 27, 2001 at 05:47:09PM +0200, Ruslan Ermilov wrote: > On Tue, Nov 27, 2001 at 07:35:44AM -0800, Dag-Erling Smorgrav wrote: > > des 2001/11/27 07:35:44 PST > > > > Modified files: > > contrib/libpam/libpam pam_item.c > > Log: > > It's idiotic to return PAM_PERM_DENIED when the item argument is NULL; > > PAM_BUF_ERR is much closer to the truth. > > > > Revision Changes Path > > 1.2 +102 -81 src/contrib/libpam/libpam/pam_item.c > > > DES! > > Please keep this out from commitlogs. When did we get so "Politically Correct"? Geez people is it now desired we turn into drones? I sense frustration in DES's message and it was probably a goose-chase debugging session that led him to the problem. Thus the furstraition was founded. I hope their ears are burning and it shames them into fixing it. :-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message