From owner-cvs-src@FreeBSD.ORG Thu Feb 26 00:04:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24A6616A4CE; Thu, 26 Feb 2004 00:04:14 -0800 (PST) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5034743D1F; Thu, 26 Feb 2004 00:04:13 -0800 (PST) (envelope-from tim@robbins.dropbear.id.au) Received: from robbins.dropbear.id.au (210.50.80.80) by smtp01.syd.iprimus.net.au (7.0.024) id 402BA92700428413; Thu, 26 Feb 2004 19:04:11 +1100 Received: by robbins.dropbear.id.au (Postfix, from userid 1000) id 99D6B415D; Thu, 26 Feb 2004 19:05:17 +1100 (EST) Date: Thu, 26 Feb 2004 19:05:17 +1100 From: Tim Robbins To: Steve Kargl Message-ID: <20040226080517.GA29763@cat.robbins.dropbear.id.au> References: <200402260234.i1Q2YDx1014240@repoman.freebsd.org> <20040226060126.GA70201@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040226060126.GA70201@troutmask.apl.washington.edu> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: Max Laier cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/pf/net if_pflog.c if_pflog.h if_pfsync.c if_pfsync.h pf.c pf_ioctl.c pf_norm.c pf_osfp.c pf_table.c pfvar.h src/sys/contrib/pf/netinet in4_cksum.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2004 08:04:14 -0000 On Wed, Feb 25, 2004 at 10:01:26PM -0800, Steve Kargl wrote: > On Wed, Feb 25, 2004 at 06:34:13PM -0800, Max Laier wrote: > > mlaier 2004/02/25 18:34:12 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/contrib/pf/net if_pflog.c if_pflog.h if_pfsync.c > > if_pfsync.h pf.c pf_ioctl.c pf_norm.c > > pf_osfp.c pf_table.c pfvar.h > > sys/contrib/pf/netinet in4_cksum.c > > Log: > > Bring diff from the security/pf port. This has code been tested as a port > > for a long time and is run in production use. This is the code present in > > portversion 2.03 with some additional tweaks. > > > > The rather extensive diff accounts for: > > - locking (to enable pf to work with a giant-free netstack) > > - byte order difference between OpenBSD and FreeBSD for ip_len/ip_off > > - conversion from pool(9) to zone(9) > > - api differences etc. > > > > Approved by: bms(mentor) (in general) > > > > Was this import discussed on arch@ or current@? We now have ipfw, ipfilter, > and pf in the base system. How many more firewall packages are we going > to import into the base system? Are you going to remove ipfw or ipfilter? > Is there a NO_PF make.conf knob? You forgot about ip6fw. I agree that having 4 firewalls in the base system is somewhat excessive, but not importing pf is not a solution to the problem of having too many firewalls. What I'd like to see is ipfw, ipfilter and ip6fw implemented in terms of the pf kernel code, then eventually phased out after a few releases. With the exception of dummynet, this should be fairly straightforward. If you're worried about the size of the base system, there are plenty of other rarely-used features that could be removed to "make room" for pf. Tim