Date: Sat, 29 Jul 2023 05:17:24 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Fernando Apestegu??a <fernape@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0 Message-ID: <ZMSg5A-a77EDobnZ@FreeBSD.org> In-Reply-To: <CAGwOe2YcXfogxwCODdHvOLPZExeXC_BN4knB3obFb_7EQUuA-g@mail.gmail.com> References: <202307281248.36SCmERV027986@gitrepo.freebsd.org> <ZMO8UT68PlITqFuB@FreeBSD.org> <CAGwOe2YcXfogxwCODdHvOLPZExeXC_BN4knB3obFb_7EQUuA-g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 28, 2023 at 04:40:11PM +0200, Fernando Apestegu??a wrote: > El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi??: > > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote: > > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19 > > > > > > cad/PrusaSlicer: update to 2.6.0 > > > > > > PR: 272730 > > > Reported by: michal.zielonka.8001@gmail.com > > > Approved by: teodorsigaev@gmail.com (maintainer) > > > --- > > > cad/PrusaSlicer/Makefile | 14 +- > > > cad/PrusaSlicer/distinfo | 6 +- > > > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +- > > > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +- > > > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 + > > > .../files/patch-src_libnanosvg_nanosvg.h | 3109 > > ++++++++++++++++++++ > > > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++++ > > > > Who reviewed this? First, we don't create files via patches, and > > Maintainer did. It's in the commit log and in the PR. Which means they don't have a clue, and you as committer should have requested this whole mess reworked, not checked in as is. These are the basics your mentor should have explained, did he not? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZMSg5A-a77EDobnZ>