From owner-p4-projects@FreeBSD.ORG  Thu Feb  3 07:23:02 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 38B0E16A4D0; Thu,  3 Feb 2005 07:23:02 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1204A16A4CE
	for <perforce@freebsd.org>; Thu,  3 Feb 2005 07:23:02 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EF96943D39
	for <perforce@freebsd.org>; Thu,  3 Feb 2005 07:23:01 +0000 (GMT)
	(envelope-from des@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j137N19P009641
	for <perforce@freebsd.org>; Thu, 3 Feb 2005 07:23:01 GMT
	(envelope-from des@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j137N1dB009638
	for perforce@freebsd.org; Thu, 3 Feb 2005 07:23:01 GMT
	(envelope-from des@freebsd.org)
Date: Thu, 3 Feb 2005 07:23:01 GMT
Message-Id: <200502030723.j137N1dB009638@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	des@freebsd.org using -f
From: Dag-Erling Smorgrav <des@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 70219 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2005 07:23:02 -0000

http://perforce.freebsd.org/chv.cgi?CH=70219

Change 70219 by des@des.at.des.thinksec.com on 2005/02/03 07:22:02

	Better to use unsigned char when isspace() is involved.

Affected files ...

.. //depot/projects/openpam/lib/openpam_readline.c#3 edit

Differences ...

==== //depot/projects/openpam/lib/openpam_readline.c#3 (text+ko) ====

@@ -31,7 +31,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/openpam/lib/openpam_readline.c#2 $
+ * $P4: //depot/projects/openpam/lib/openpam_readline.c#3 $
  */
 
 #include <ctype.h>
@@ -52,7 +52,7 @@
 char *
 openpam_readline(FILE *f, int *lineno, size_t *lenp)
 {
-	char *line;
+	unsigned char *line;
 	size_t len, size;
 	int ch;
 
@@ -63,7 +63,7 @@
 
 #define line_putch(ch) do { \
 	if (len >= size - 1) { \
-		char *tmp = realloc(line, size *= 2); \
+		unsigned char *tmp = realloc(line, size *= 2); \
 		if (tmp == NULL) \
 			goto fail; \
 		line = tmp; \