From owner-freebsd-current@FreeBSD.ORG  Tue Jul 22 16:57:58 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B0FEA37B401; Tue, 22 Jul 2003 16:57:58 -0700 (PDT)
Received: from mailout.informatik.tu-muenchen.de
	(mailout.informatik.tu-muenchen.de [131.159.0.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 03A4843F93; Tue, 22 Jul 2003 16:57:58 -0700 (PDT)
	(envelope-from barner@in.tum.de)
Received: by zi025.glhnet.mhn.de (Postfix, from userid 1000)
	id B04DE38894; Wed, 23 Jul 2003 01:57:56 +0200 (CEST)
Date: Wed, 23 Jul 2003 01:57:56 +0200
From: Simon Barner <barner@in.tum.de>
To: "Jacques A. Vidrine" <nectar@FreeBSD.org>
Message-ID: <20030722235756.GB607@zi025.glhnet.mhn.de>
References: <20030718025200.GA36893@rot13.obsecurity.org>
	<20030722122608.GC552@zi025.glhnet.mhn.de>
	<20030722195637.GC10922@madman.celabo.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW"
Content-Disposition: inline
In-Reply-To: <20030722195637.GC10922@madman.celabo.org>
User-Agent: Mutt/1.5.4i
X-Virus-Scanned: by amavisd-new at informatik.tu-muenchen.de
cc: ports@FreeBSD.org
cc: current@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2003 23:57:59 -0000


--b5gNqxB1S1yM7hjW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> > --- plugins/check_by_ssh.c.orig	Mon Apr 23 09:43:11 2001
> > +++ plugins/check_by_ssh.c	Tue Jul 22 05:05:52 2003
> > @@ -191,7 +191,7 @@
> >  	if (commands>1)
> >  		remotecmd=3Dstrscat(remotecmd,";echo STATUS CODE: $?;");
> > =20
> > -	if (strlen (remotecmd) <=3D 1)
> > +	if (remotecmd=3D=3DNULL)
> >  		usage ("No remotecmd\n");
> > =20
> >  	comm =3D ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);
>=20
> This looks like more than a fix for a `compile failure'.  The
> replacement code has different semantics than the new code.
> What is the `compile failure' that was being fixed here?

I don't know, either. This patch was part of the port before I touched
it [1]. Perhaps one should write

if ((remotecmd=3D=3DNULL) || (strlen (remotecmd) <=3D 1))

to be on the safe side?

Cheers,
 Simon
=20
[1]:
http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/net/netsaint-plugins=
/files/patch-check_by_ssh.c?rev=3D1.1&content-type=3Dtext/plain

--b5gNqxB1S1yM7hjW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)

iD8DBQE/Hc+ECkn+/eutqCoRAuLKAJ4pE3Om4ayyfP9iHM5D44urINswLwCfTDlO
TIsgHpo+igePCwH/B1rRzkI=
=ihRM
-----END PGP SIGNATURE-----

--b5gNqxB1S1yM7hjW--