From owner-cvs-src@FreeBSD.ORG Wed Feb 23 14:03:40 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8602216A4CE; Wed, 23 Feb 2005 14:03:40 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCCE043D54; Wed, 23 Feb 2005 14:03:39 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id B2485530C; Wed, 23 Feb 2005 15:03:33 +0100 (CET) Received: from xps.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 9CE275308; Wed, 23 Feb 2005 15:03:22 +0100 (CET) Received: by xps.des.no (Postfix, from userid 1001) id 60E5633C3E; Wed, 23 Feb 2005 15:03:22 +0100 (CET) To: Gleb Smirnoff References: <200502220803.j1M839fn013604@repoman.freebsd.org> <20050222021322.U702@odysseus.silby.com> <20050222082558.GB10624@cell.sick.ru> <20050223043325.X718@odysseus.silby.com> <20050223134627.GA21396@cell.sick.ru> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Wed, 23 Feb 2005 15:03:22 +0100 In-Reply-To: <20050223134627.GA21396@cell.sick.ru> (Gleb Smirnoff's message of "Wed, 23 Feb 2005 16:46:27 +0300") Message-ID: <863bvnl6fp.fsf@xps.des.no> User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on flood.des.no X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=AWL,FORGED_RCVD_HELO autolearn=disabled version=3.0.1 cc: cvs-src@freebsd.org cc: Mike Silbersack cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/etc syslog.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2005 14:03:40 -0000 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Gleb Smirnoff writes: > Yes, a good plan. btw, syslogd does some ratelimiting itself. However, wh= en > system is low on kernel memory, new valid ARP entries fail to install > with _two_ debug messages. Since two different messages are printed one > after other, syslogd's limiting does not work. Example: > > Feb 2 09:00:01 gw-core1 /kernel: arplookup 217.72.145.208 f= ailed:=20 > could not allocate llinfo > Feb 2 09:00:01 gw-core1 /kernel: arpresolve: can't allocate= llinfo > for 217.72.145.208rt The second message can simply be removed, since (from my quick reading of the code) it can only occur if the first has already occurred. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=arplookup.diff Index: sys/netinet/if_ether.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/if_ether.c,v retrieving revision 1.133 diff -u -r1.133 if_ether.c --- sys/netinet/if_ether.c 7 Jan 2005 01:45:44 -0000 1.133 +++ sys/netinet/if_ether.c 23 Feb 2005 14:02:38 -0000 @@ -388,9 +388,6 @@ rt = la->la_rt; } if (la == 0 || rt == 0) { - log(LOG_DEBUG, "arpresolve: can't allocate llinfo for %s%s%s\n", - inet_ntoa(SIN(dst)->sin_addr), la ? "la" : "", - rt ? "rt" : ""); m_freem(m); return (EINVAL); /* XXX */ } --=-=-=--