From owner-freebsd-current@FreeBSD.ORG Thu Mar 2 12:52:58 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54CC116A420 for ; Thu, 2 Mar 2006 12:52:58 +0000 (GMT) (envelope-from rea@rea.mbslab.kiae.ru) Received: from rea.mbslab.kiae.ru (rea.mbslab.kiae.ru [144.206.177.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF23C43D46 for ; Thu, 2 Mar 2006 12:52:57 +0000 (GMT) (envelope-from rea@rea.mbslab.kiae.ru) Received: from rea.mbslab.kiae.ru (localhost [127.0.0.1]) by rea.mbslab.kiae.ru (Postfix) with ESMTP id 8E0FABC65; Thu, 2 Mar 2006 15:52:55 +0300 (MSK) Received: by rea.mbslab.kiae.ru (Postfix, from userid 1000) id 6DF4FB967; Thu, 2 Mar 2006 15:52:55 +0300 (MSK) Date: Thu, 2 Mar 2006 15:52:55 +0300 From: FreeLSD To: Dmitry Pryanishnikov Message-ID: <20060302125255.GI1107@rea.mbslab.kiae.ru> References: <20060302105229.P83093@atlantis.atlantis.dp.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060302105229.P83093@atlantis.atlantis.dp.ua> User-Agent: mutt-ng/devel-r581 (FreeBSD) X-AV-Checked: Yes! Cc: freebsd-current@freebsd.org Subject: Re: style(9) question X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2006 12:52:58 -0000 > Values in return statements should be enclosed in parentheses. > > What's the rationale of this? From time to time I see small commits > just changing "return foo;" -> "return (foo);". I think the first form > is quite natural and not ambiguous. Shouldn't we remove this advise from > style(9)? Don't know about the exact reason for "return (foo);" grammar, but for such small commits I can say, that there are another point in style(9): ----- Stylistic changes (including whitespace changes) are hard on the source repository and are to be avoided without good reason. Code that is approximately FreeBSD KNF style compliant in the repository must not diverge from compliance. ----- So, such small commits are not very clever. By the way: I am also interested about the return (foo) rationale ;) -- Yours, LSD BOFH excuse #302: microelectronic Riemannian curved-space fault in write-only file system