Date: Thu, 2 Mar 2006 15:52:55 +0300 From: FreeLSD <freelsd@rea.mbslab.kiae.ru> To: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> Cc: freebsd-current@freebsd.org Subject: Re: style(9) question Message-ID: <20060302125255.GI1107@rea.mbslab.kiae.ru> In-Reply-To: <20060302105229.P83093@atlantis.atlantis.dp.ua> References: <20060302105229.P83093@atlantis.atlantis.dp.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
> Values in return statements should be enclosed in parentheses.
>
> What's the rationale of this? From time to time I see small commits
> just changing "return foo;" -> "return (foo);". I think the first form
> is quite natural and not ambiguous. Shouldn't we remove this advise from
> style(9)?
Don't know about the exact reason for "return (foo);" grammar, but for such
small commits I can say, that there are another point in style(9):
-----
Stylistic changes (including whitespace changes) are hard on the source
repository and are to be avoided without good reason. Code that is
approximately FreeBSD KNF style compliant in the repository must not
diverge from compliance.
-----
So, such small commits are not very clever.
By the way: I am also interested about the return (foo) rationale ;)
--
Yours, LSD
BOFH excuse #302:
microelectronic Riemannian curved-space fault in write-only file system
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060302125255.GI1107>