From owner-freebsd-apache@FreeBSD.ORG Fri Jan 7 18:42:15 2011 Return-Path: Delivered-To: apache@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7019A106566C; Fri, 7 Jan 2011 18:42:15 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: from EXHUB015-4.exch015.msoutlookonline.net (exhub015-4.exch015.msoutlookonline.net [207.5.72.96]) by mx1.freebsd.org (Postfix) with ESMTP id 535618FC13; Fri, 7 Jan 2011 18:42:15 +0000 (UTC) Received: from philip.hq.rws (174.79.184.239) by smtpx15.msoutlookonline.net (207.5.72.103) with Microsoft SMTP Server (TLS) id 8.2.254.0; Fri, 7 Jan 2011 10:42:14 -0800 Message-ID: <4D275E83.2000204@p6m7g8.com> Date: Fri, 7 Jan 2011 18:42:11 +0000 From: "Philip M. Gollucci" Organization: P6M7G8 Inc. User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.16) Gecko/20101213 Thunderbird/3.0.11 MIME-Version: 1.0 To: References: <4D243209.5040703@FreeBSD.org> <4D24BED1.7070004@p6m7g8.com> <4D265CF2.5090208@FreeBSD.org> <4D26B3C6.4050804@p6m7g8.com> <4D272510.9030908@FreeBSD.org> In-Reply-To: <4D272510.9030908@FreeBSD.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1C78A18CBDD9AC7B65204081" Cc: "Philip M. Gollucci" , apache@FreeBSD.org Subject: Re: question about PR: ports/147009: Mk/bsd.apache.mk: [patch] default to www/apache22 X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 18:42:15 -0000 --------------enig1C78A18CBDD9AC7B65204081 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 01/07/11 14:37, Olli Hauer wrote: > However I'm a friend of more explicit test, so I like this more. >=20 > .elif ${USE_APACHE:C/\.//:C/\+//:C/13//:C/20//:C/22//:C/24//} =3D=3D ""= > or > .elif ${USE_APACHE:C/\.//:C/\+//:S/^13//:S/^20//:S/^22//:S/^24//} =3D=3D= "" Seems logical. > The following lines in bsd.apache.mk should be reviewed, for example > APACHE_SUPPORTED_VERSION is nowhere used in ports/MK/* This is used in some ports though I'm not sure I'm a fan of it. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > USE_APACHE=3D 1.3 / 13 =3D> APACHE_VERSION=3D13, make: error version .= =2E. this shouldn't fail, it should use 13 > USE_APACHE=3D 1.3+/13+ =3D> APACHE_VERSION=3D22, make: OK >=20 > USE_APACHE=3D 2.0 / 20 =3D> APACHE_VERSION=3D20, make: error version .= =2E. ditto above, should use 20 > USE_APACHE=3D 2.0+/20+ =3D> APACHE_VERSION=3D22, make: OK >=20 > USE_APACHE=3D 2.2 / 22 =3D> APACHE_VERSION=3D22, make: OK > USE_APACHE=3D 2.2+/ 22+ =3D> APACHE_VERSION=3D22, make: OK >=20 > USE_APACHE=3D 2.4 / 24 =3D> APACHE_VERSION=3D24, make: error version .= =2E. > USE_APACHE=3D 2.4+/ 24+ =3D> APACHE_VERSION=3D24, make: error version .= =2E. both of these should use 24 bsd.perl.mk / bsd.python.mk might be helpful for the 'range' or -+ logic though I'm not sure its compatible. --=20 ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. --------------enig1C78A18CBDD9AC7B65204081 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iD8DBQFNJ16FdbiP+9ubjBwRAk3FAJ9X+oWxxujSsWzs8aRvXGFJocHKQQCffBRn 2QSkpkzDCWy/i1V4HEshhE4= =tanM -----END PGP SIGNATURE----- --------------enig1C78A18CBDD9AC7B65204081--