From owner-freebsd-ports@FreeBSD.ORG Sun May 24 16:28:04 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A016106568E for ; Sun, 24 May 2009 16:28:04 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from raven.customer.vol.cz (raven.customer.vol.cz [195.250.144.108]) by mx1.freebsd.org (Postfix) with ESMTP id D9E1D8FC13 for ; Sun, 24 May 2009 16:28:03 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from [192.168.0.23] (r5af140.net.upc.cz [86.49.39.140]) (authenticated bits=0) by raven.customer.vol.cz (8.14.3/8.14.3) with ESMTP id n4OGRviO026579; Sun, 24 May 2009 18:27:57 +0200 (CEST) (envelope-from pav@FreeBSD.org) From: Pav Lucistnik To: Ion-Mihai Tetcu In-Reply-To: <20090524190131.0b30b101@it.buh.tecnik93.com> References: <20090522.195350.193746535.chat95@mac.com> <20090522164138.236cb114@it.buh.tecnik93.com> <200905231101.59467.naylor.b.david@gmail.com> <20090523.182426.193741786.chat95@mac.com> <20090523135133.71a92669@it.buh.tecnik93.com> <1243174223.18007.2.camel@hood.oook.cz> <20090524190131.0b30b101@it.buh.tecnik93.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-nIKWlqIVLrOmVK6xVCOI" Date: Sun, 24 May 2009 18:27:57 +0200 Message-Id: <1243182477.18007.18.camel@hood.oook.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 FreeBSD GNOME Team Port X-Spam-Score: -1.479 () AWL,BAYES_00,RCVD_IN_PBL X-Scanned-By: MIMEDefang 2.64 on 195.250.144.108 Cc: pgollucci@p6m7g8.com, naylor.b.david@gmail.com, freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2009 16:28:04 -0000 --=-nIKWlqIVLrOmVK6xVCOI Content-Type: text/plain; charset="ISO-8859-2" Content-Transfer-Encoding: quoted-printable Ion-Mihai Tetcu p=ED=B9e v ne 24. 05. 2009 v 19:01 +0300: > On Sun, 24 May 2009 16:10:23 +0200 > Pav Lucistnik wrote: >=20 > > Ion-Mihai Tetcu p=ED=B9e v so 23. 05. 2009 v 13:51 +0300: > >=20 > > > > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of > > > > > cores > > >=20 > > > This part looks OK, I wonder if there's any reason t ain't like this > > > now; Pav? > > > -.if defined(MAKE_JOBS_NUMBER) > > > +MAKE_JOBS_NUMBER?=3D `${SYSCTL} -n kern.smp.cpus` > > > _MAKE_JOBS=3D -j${MAKE_JOBS_NUMBER} > > > -.else > > > -_MAKE_JOBS=3D -j`${SYSCTL} -n kern.smp.cpus` > > > -.endif > >=20 > > Wouldn't that mean an evaluation of the backtick command in every > > make(1) invocation? That would be highly undesirable. >=20 > Umm, why? it shouldn't be evaluated if MAKE_JOBS_NUMBER is defined, no? > Am I missing some make magic here? But for 99.99% of the users, MAKE_JOBS_NUMBER is not defined. --=20 Pav Lucistnik ... the obese drugged penguin used by Linux. -- Scott Long --=-nIKWlqIVLrOmVK6xVCOI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkoZdY0ACgkQntdYP8FOsoKUqQCfSPfbVQvN1IEAE9GZ5WP+eoG6 JqoAn0+iFUpBDjBH+dO0+Hl2BXz8cH2p =05gn -----END PGP SIGNATURE----- --=-nIKWlqIVLrOmVK6xVCOI--