From owner-freebsd-net@freebsd.org Mon Mar 6 08:06:05 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA65ECFB615 for ; Mon, 6 Mar 2017 08:06:05 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x22c.google.com (mail-ua0-x22c.google.com [IPv6:2607:f8b0:400c:c08::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 762A61726 for ; Mon, 6 Mar 2017 08:06:05 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x22c.google.com with SMTP id u30so26476414uau.0 for ; Mon, 06 Mar 2017 00:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mPQjXPN7ZjSiC3lu4vKcArGYEmU9gcatLLJTEOAsDa4=; b=dv42g8lzAG7k/Df8w9oh7MyrmnTeKvS0IX/28C1QWO8EPbvxepE0GcxkjFt+Wq4ZEd TzFHMOYhxPghBQGq4QjjLp8HXm4kunkLOIzr7evKNLHw1zzsr29V5zTms/eM+/DEYjTu 2vN9hcfNR9NjGHlxLhazXJqSJ01th1cWA8uHsPeIinLDM/y120oeqHr0NJt2p3Udut1S sZ7B0Fb919UulqQpvjWaYHKFhAlXy4r76uuOAriaZ8+HdvDjZgGIL5r2wmaPRcK/r05r IEwwxoxJQZurwKYUlyP6gnGiHsdX24htd9vY5yUMLSJHpHHkQh83q4Sei8VzKQMZBJ2V wreg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mPQjXPN7ZjSiC3lu4vKcArGYEmU9gcatLLJTEOAsDa4=; b=IfhelsApFOJeBrXXxBTHWIK8g0LmCLotRfodvGT++0+hOzCTizwOLE9jGKWhqUP0B9 42ZDsCSBb18k464za8WrNIy2xwFsrgAkK3kWjVWdtT0vy0pbpJiNHd2qs5odbSJcMSIe IO7gIH1sqqp+B13epw9hdCxKaANTDXn9xwuVnPFpMuDZ8EY6ve9t9Y9Wj8DEFNtYb8n9 ryBdJKmtbPTq/3kTmvhi6cEDcGdKAnsS5SXot0bObDAUkZpqQupp+dl5/B/x6ndHWyqx i7yTwG+9FWuoszCMlvcAkfncU3lEOMgIJ5otPC08YMLJohH5yxiROzx/fdtcCC5lgU1N nCFw== X-Gm-Message-State: AMke39nMQ+vRxf51nsjVxmIT6gbglth46TZum/vMIg8DW4xo09cRAyifYbL+7xYIcz2VIYOq4iXx47Yd4axB1g== X-Received: by 10.176.5.38 with SMTP id 35mr7003087uax.71.1488787564526; Mon, 06 Mar 2017 00:06:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Mon, 6 Mar 2017 00:06:03 -0800 (PST) In-Reply-To: <1946092.tUUkk3b7I7@energia> References: <1946092.tUUkk3b7I7@energia> From: Sepherosa Ziehau Date: Mon, 6 Mar 2017 16:06:03 +0800 Message-ID: Subject: Re: Why is MSI-X support disabled on bce(4)? To: Kajetan Staszkiewicz Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 08:06:05 -0000 On Thu, Mar 2, 2017 at 10:02 PM, Kajetan Staszkiewicz wrote: > To whom it might concern: > > Well, at least it does concern me. Why is support for multiple interrupts and > queues not enabled on bce(4)? > > Whole block of code is surrounded with #ifdef 0 ... #endif > > https://github.com/freebsd/freebsd/blob/master/sys/dev/bce/if_bce.c#L1108 It involves much more work than the commented out MSI-X allocation, like this: https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/b42386ee03a4e688c864ba8d7094064c63d93dce?hp=be5708901d52be5534d5075eec706f5570b6a0f3 Thanks, sephe -- Tomorrow Will Never Die