From owner-freebsd-stable@FreeBSD.ORG Sat Aug 4 17:52:50 2007 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD63416A468 for ; Sat, 4 Aug 2007 17:52:50 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from mail.farley.org (farley.org [67.64.95.201]) by mx1.freebsd.org (Postfix) with ESMTP id B2E2B13C4E5 for ; Sat, 4 Aug 2007 17:52:50 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from baba.farley.org (baba.farley.org [192.168.1.211]) by mail.farley.org (8.14.1/8.14.1) with ESMTP id l74HqR5o017129; Sat, 4 Aug 2007 12:52:27 -0500 (CDT) (envelope-from scf@FreeBSD.org) Date: Sat, 4 Aug 2007 12:52:27 -0500 (CDT) From: "Sean C. Farley" To: Pieter de Goeje In-Reply-To: <200708040218.28169.pieter@degoeje.nl> Message-ID: <20070804124802.L1107@baba.farley.org> References: <20070802114827.U26646@pat.io.com> <200708040129.58761.pieter@degoeje.nl> <20070803184340.L84415@thor.farley.org> <200708040218.28169.pieter@degoeje.nl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.1 X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on mail.farley.org Cc: Xin LI , freebsd-stable@FreeBSD.org, Ted Hatfield Subject: Re: Bug in less version 406. X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2007 17:52:50 -0000 On Sat, 4 Aug 2007, Pieter de Goeje wrote: > On Saturday 04 August 2007, Sean C. Farley wrote: >> On Sat, 4 Aug 2007, Pieter de Goeje wrote: >> >> *snip* >> >>> There's also another regression in less: it doesn't automatically >>> repaint the screen anymore when you resize the terminal. >> >> I have already reported that regression to Mark Nudelman. He is >> looking into an appropriate fix since this regression was introduced >> when fixing another bug. > > Hmm I wonder what that other bug might have been... > If I look at signal.c I see two signal handlers for things related to > window changes. One for SIGWINCH and one for SIGWIND. The "if(reading) > intread();" statement was removed from the SIGWINCH handler. If > removing that statement fixed the other bug why wasn't it removed from > SIGWIND's handler? Does SIGWIND have different semantics? > > Anyway, re-adding "if(reading) intread();" to signal.c:96 makes it > work again, but I wonder what I broke by doing that. Yes, that is the fix for the resizing. This is the bug in question[1]: Fix bug when resizing the window while waiting for input from a pipe. Sean 1. http://www.greenwoodsoftware.com/less/news.406.html -- scf@FreeBSD.org