From owner-freebsd-current@FreeBSD.ORG Wed Nov 10 16:31:20 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2573B1065679 for ; Wed, 10 Nov 2010 16:31:20 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 997BD8FC1C for ; Wed, 10 Nov 2010 16:31:19 +0000 (UTC) Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.4/8.14.4) with ESMTP id oAAG7Aef091615; Wed, 10 Nov 2010 09:07:10 -0700 (MST) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: Date: Wed, 10 Nov 2010 09:07:09 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201011081714.53637.jhb@freebsd.org> To: David Rhodus X-Mailer: Apple Mail (2.1081) X-Spam-Status: No, score=-50.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: "current@freebsd.org" Subject: Re: Only display ACPI bootmenu key if ACPI is present X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 16:31:20 -0000 If the loader can't detect acpi, the kernel can't either. Scott On Nov 10, 2010, at 9:01 AM, David Rhodus wrote: > What are the chances the detection fails and one still needs to = disable ACPI and can't because it's not showing as a option ? >=20 > Thanks, > David Rhodus >=20 > On Nov 8, 2010, at 5:14 PM, John Baldwin wrote: >=20 >> This patch changes the Forth code for the Beastie menu to only = display the >> menu option to enable or disable ACPI if the loader detects ACPI. = This avoids >> displaying a menu item prompting to enable ACPI if the BIOS doesn't = actually >> include ACPI. Any objections? >>=20 >> --- //depot/projects/smpng/sys/boot/forth/beastie.4th 2010-11-08 = 21:53:18.000000000 0000 >> +++ //depot/user/jhb/ktrace/boot/forth/beastie.4th 2010-11-08 = 22:14:04.000000000 0000 >> @@ -140,12 +140,16 @@ >> fbsdbw-logo >> ; >>=20 >> -: acpienabled? ( -- flag ) >> +: acpipresent? ( -- flag ) >> s" hint.acpi.0.rsdp" getenv >> dup -1 =3D if >> drop false exit >> then >> 2drop >> + true >> +; >> + >> +: acpienabled? ( -- flag ) >> s" hint.acpi.0.disabled" getenv >> dup -1 <> if >> s" 0" compare 0<> if >> @@ -178,8 +182,7 @@ >> 42 20 2 2 box >> 13 6 at-xy ." Welcome to FreeBSD!" >> printmenuitem ." Boot FreeBSD [default]" bootkey ! >> - s" arch-i386" environment? if >> - drop >> + acpipresent? if >> printmenuitem ." Boot FreeBSD with ACPI " bootacpikey ! >> acpienabled? if >> ." disabled" >>=20 >> --=20 >> John Baldwin >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to = "freebsd-current-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to = "freebsd-current-unsubscribe@freebsd.org"