From owner-freebsd-bugs@FreeBSD.ORG  Fri Mar  5 10:18:53 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CB4F616A4CE; Fri,  5 Mar 2004 10:18:53 -0800 (PST)
Received: from ice.42.org (ice.42.org [194.77.3.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 508D543D31; Fri,  5 Mar 2004 10:18:53 -0800 (PST)
	(envelope-from sec@42.org)
Received: by ice.42.org (Postfix, from userid 1000)
	id 8BA761C8BA; Fri,  5 Mar 2004 19:18:52 +0100 (CET)
Date: Fri, 5 Mar 2004 19:18:52 +0100
From: Stefan `Sec` Zehl <sec@42.org>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Message-ID: <20040305181852.GC21713@ice.42.org>
References: <20040304191443.67E9B1C8BA@ice.42.org>
	<200403041920.i24JK826047989@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200403041920.i24JK826047989@freefall.freebsd.org>
User-Agent: Mutt/1.4.1i
I-love-doing-this: really
X-Modeline: vim:set ts=8 sw=4 smarttab tw=72 si noic notitle:
Accept-Languages: de, en
X-URL: http://sec.42.org/
Subject: Re: kern/63772: tap device / exclusive open problem
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2004 18:18:54 -0000

On Thu, Mar 04, 2004 at 11:20 -0800, FreeBSD-gnats-submit@FreeBSD.org wrote:
> Thank you very much for your problem report.
> It has the internal identification `kern/63772'.

I have checked the if_tap.c in the current and stable branches, and was
thus able to come up with an easy fix:

--- if_tap.c    Tue Feb 24 05:35:44 2004
+++ if_tap.c.neu        Fri Mar  5 19:09:12 2004
@@ -323,6 +323,9 @@
        KASSERT(!(tp->tap_flags & TAP_OPEN), 
                ("%s flags is out of sync", tp->tap_if.if_xname));
 
+       if (tp->tap_flags & TAP_OPEN)
+               return (EBUSY);
+
        bcopy(tp->arpcom.ac_enaddr, tp->ether_addr, sizeof(tp->ether_addr));
 
        tp->tap_pid = td->td_proc->p_pid;


After this simple change, openvpn works with multiple tunnels again.

I hope this can be committed.

CU,
    Sec
-- 
"Caution, you have *no chance* of operating this device successfully
unless you have read the instruction manual."
- from a card covering the screen of an Amstrad phone