From owner-freebsd-arch@FreeBSD.ORG Wed Feb 29 12:04:47 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32A4C106566B for ; Wed, 29 Feb 2012 12:04:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 9521A8FC1B for ; Wed, 29 Feb 2012 12:04:46 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q1TC4VLB084001; Wed, 29 Feb 2012 14:04:31 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q1TC4Vrd094904; Wed, 29 Feb 2012 14:04:31 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q1TC4V88094903; Wed, 29 Feb 2012 14:04:31 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 29 Feb 2012 14:04:31 +0200 From: Konstantin Belousov To: d@delphij.net Message-ID: <20120229120431.GX55074@deviant.kiev.zoral.com.ua> References: <4F4DC876.3010809@delphij.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3BXhlsXkTW/kybY4" Content-Disposition: inline In-Reply-To: <4F4DC876.3010809@delphij.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-arch@freebsd.org Subject: Re: RFC: futimens(2) and utimensat(2) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Feb 2012 12:04:47 -0000 --3BXhlsXkTW/kybY4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2012 at 10:40:54PM -0800, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 >=20 > Hi, >=20 > These are required by IEEE Std 1003.1-2008. Patchset at: >=20 > http://people.freebsd.org/~delphij/for_review/utimens.diff The patch looks fine, I have only some stylistic comments. You misordered the functions both in Symbol.map and in the man page. The kern_utimensat() definition would benefit from making the second line of the function shorter then 80 columns. I suggest to use a local struct vnode *vp variable instead of dereferencing fp->f_vnode on each line. Put error and vfslocked declarations in kern_futimens on the same line. I do not see a need in having _SYS_SYSPROTO_H_ for new syscalls. We always do have sysproto.h. And, omiting the generated files from the patch would make it easier to rea= d. --3BXhlsXkTW/kybY4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9OFE8ACgkQC3+MBN1Mb4hykQCg27zu75p6Z/Uj4K7YlW6E6V0C NNoAn3RtY6vmZj1K61oVfOQuM6c5trM3 =O1m5 -----END PGP SIGNATURE----- --3BXhlsXkTW/kybY4--