From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 28 01:30:22 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 967D516A41F for ; Sun, 28 Aug 2005 01:30:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B9B143D48 for ; Sun, 28 Aug 2005 01:30:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7S1UL0W054071 for ; Sun, 28 Aug 2005 01:30:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7S1ULd5054070; Sun, 28 Aug 2005 01:30:21 GMT (envelope-from gnats) Resent-Date: Sun, 28 Aug 2005 01:30:21 GMT Resent-Message-Id: <200508280130.j7S1ULd5054070@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02A4216A41F for ; Sun, 28 Aug 2005 01:21:02 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id DAF2D43D53 for ; Sun, 28 Aug 2005 01:20:59 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.4/8.13.4) with ESMTP id j7S1Kv45002470 for ; Sun, 28 Aug 2005 03:20:58 +0200 (CEST) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.4/8.13.1/Submit) id j7S1KvkE002469; Sun, 28 Aug 2005 03:20:57 +0200 (CEST) (envelope-from dan) Message-Id: <200508280120.j7S1KvkE002469@kulesh.obluda.cz> Date: Sun, 28 Aug 2005 03:20:57 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/85366: [ PATCH ] MSDOSFS doesn't mark volume "clean" (sometime) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Aug 2005 01:30:22 -0000 >Number: 85366 >Category: kern >Synopsis: [ PATCH ] MSDOSFS doesn't mark volume "clean" (sometime) >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 28 01:30:21 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 6.0-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD 6.0-BETA3: Sat Aug 27 17:43:26 CEST 2005 i386 src/sys/fs/msdosfs/msdosfs_vfsops.c,v 1.144 2005/03/24 07:36:13 >Description: The msdosfs doesn't mark volume as clean when mount downgraded to read-only. In advance, the volume is not marked clean even if the volume is dismounted later. >How-To-Repeat: >Fix: Mark the volume clean when downgraded to RO: --- patch begins here --- --- msdosfs_vfsops.c.ORIG Thu Mar 24 08:36:13 2005 +++ msdosfs_vfsops.c Sun Aug 28 02:40:40 2005 @@ -285,6 +285,10 @@ g_access(pmp->pm_cp, 0, -1, 0); g_topology_unlock(); PICKUP_GIANT(); + /* Now the volume is clean. Mark it. */ + error = markvoldirty(pmp, 0); + if (error) + return (error); } else if ((pmp->pm_flags & MSDOSFSMNT_RONLY) && !vfs_flagopt(mp->mnt_optnew, "ro", NULL, 0)) { /* --- patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: