From owner-freebsd-testing@FreeBSD.ORG Wed Apr 2 17:21:28 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9BF9CE46 for ; Wed, 2 Apr 2014 17:21:28 +0000 (UTC) Received: from mail-lb0-x22c.google.com (mail-lb0-x22c.google.com [IPv6:2a00:1450:4010:c04::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25596D9A for ; Wed, 2 Apr 2014 17:21:27 +0000 (UTC) Received: by mail-lb0-f172.google.com with SMTP id c11so424318lbj.31 for ; Wed, 02 Apr 2014 10:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=l6qca9mZM/YXp7tOUYoX0WSWd6IPUZcHwlXrksi0BTc=; b=YoAMi+kfa/SG/fFtM0WFECw+VWZSWilxoRIN3p5dvlpJNGX7V4gf+IkD80zaSoLnTk /dGhBWfzdW3cl8Q00qQhFdnbQksK9CIImNnjzBudRbv9E1SSPvGG/xVg/NPfwaAdRcgq dJaN/gKvVwiDz0Dank494gaeJ9mGfQFc6SzV8BdPws6nQC+8o8NAsk9WJ/JI00HU9nSJ PJOVZPIyaeoi1LZFVCFz+85lOr7cPXZuwHaIhFQUWVVUsUchvNMUcqjHb5KPsVmQbPph 838kGpTbUwUCJWoGuiJXZE5EpbR4Cu7cUL8xiZqrPTWM2+7K9rRjsdyuniMlt882e/pW COtQ== MIME-Version: 1.0 X-Received: by 10.112.241.73 with SMTP id wg9mr770122lbc.48.1396459286153; Wed, 02 Apr 2014 10:21:26 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.169.68 with HTTP; Wed, 2 Apr 2014 10:21:26 -0700 (PDT) In-Reply-To: References: <20140402085349.GA61802@x2.osted.lan> Date: Wed, 2 Apr 2014 10:21:26 -0700 X-Google-Sender-Auth: Yry-rxPp2ZULHr-NXenm1ENH3L0 Message-ID: Subject: Re: ATF work From: Craig Rodrigues To: Peter Holm Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 17:21:28 -0000 On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers wrote: > On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm wrote: >> I have uploaded a snapshot of the ATF work done for EMC Isilon, >> based primarily on Garrett Cooper's work. >> >> http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz >> + >> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr > > Holy patch queue, Batman! There's fifty thousand lines of code in here! When a patch is that big, it becomes very difficult to review. You might want to consider forking a copy on github of the https://github.com/freebsd/freebsd repository and maintaining the patch there until it is MFC'd: https://help.github.com/articles/fork-a-repo https://help.github.com/articles/syncing-a-fork It's not perfect but some of the web interface tools around the github ecosystem make reviewing patches (and contributing updates) a bit easier. -- Craig