From owner-cvs-all  Fri May 19  8: 5:37 2000
Delivered-To: cvs-all@freebsd.org
Received: from tomts2-srv.bellnexxia.net (tomts2.bellnexxia.net [209.226.175.140])
	by hub.freebsd.org (Postfix) with ESMTP
	id 271AF37BF11; Fri, 19 May 2000 08:05:19 -0700 (PDT)
	(envelope-from hoek@FreeBSD.org)
Received: from localhost.nowhere ([206.172.130.41])
          by tomts2-srv.bellnexxia.net
          (InterMail vM.4.01.02.17 201-229-119) with ESMTP
          id <20000519150509.NPJE25209.tomts2-srv.bellnexxia.net@localhost.nowhere>;
          Fri, 19 May 2000 11:05:09 -0400
Received: (from tim@localhost)
	by localhost.nowhere (8.9.3/8.9.1) id LAA33930;
	Fri, 19 May 2000 11:05:07 -0400 (EDT)
	(envelope-from tim)
Date: Fri, 19 May 2000 11:05:02 -0400
From: Tim Vanderhoek <vanderh@ecf.utoronto.ca>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/devel/libol/patches patch-aa
Message-ID: <20000519110502.B15565@mad>
References: <200005191048.DAA74511@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95i
In-Reply-To: <200005191048.DAA74511@freefall.freebsd.org>; from Maxim Sobolev on Fri, May 19, 2000 at 03:48:20AM -0700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Fri, May 19, 2000 at 03:48:20AM -0700, Maxim Sobolev wrote:
> 
>   Added files:
>     devel/libol/patches  patch-aa 
>   Log:
>   Respect CFLAGS.

Just FWIW, it's often easier to fix ports to respect CFLAGS from the
port Makefile.  In most cases (including libol) the following lines are
enough:

.if defined(USE_GMAKE)
MAKE_ARGS=	CFLAGS="${CFLAGS}"
.else
MAKE_ARGS=	-E CFLAGS
.endif

And this will fix most ports.  The difference between our make and
gmake occurs because gmake adds variables defined on the commandline
to ${.MAKEFLAGS} whereas we don't and have to explicitly request it
with either '-e' or '-E'.  I've found that sometimes '-e' breaks the
whole build altogether so prefer '-E'.

Usually just picking one of the five lines for a given port is
sufficient.  Very few ports need all five lines.  ;-)


-- 
Signature withheld by request of author.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message