From owner-freebsd-current@freebsd.org Thu Jul 9 09:21:10 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5200C9962F6 for ; Thu, 9 Jul 2015 09:21:10 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cloud.theravensnest.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E65791BB0 for ; Thu, 9 Jul 2015 09:21:09 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [192.168.0.7] (cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61]) (authenticated bits=0) by theravensnest.org (8.15.1/8.15.1) with ESMTPSA id t699KxF7098233 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Jul 2015 09:21:01 GMT (envelope-from theraven@FreeBSD.org) X-Authentication-Warning: theravensnest.org: Host cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61] claimed to be [192.168.0.7] Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: gettimeofday((void *)-1, NULL) implicates core dump on recent FreeBSD 11-CURRENT From: David Chisnall In-Reply-To: Date: Thu, 9 Jul 2015 10:21:16 +0100 Cc: Konstantin Belousov , Peter Jeremy , Doug Rabson , Jamie Landeg-Jones , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: References: <201507072241.t67MfsX5085860@hergotha.csail.mit.edu> <94BCDA65-5B86-4329-A312-4CB16E847B69@dons.net.au> <201507081616.t68GGcY9047713@dyslexicfish.net> <0C541CE5-C322-4273-AE0B-1ACAEACCA096@gmail.com> <20150708222717.GE98562@server.rulingia.com> <20150709084145.GI2080@kib.kiev.ua> To: NGie Cooper X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 09:21:10 -0000 On 9 Jul 2015, at 10:17, NGie Cooper wrote: >=20 > I agree that this is less applicable for FreeBSD than NetBSD. Please > keep in mind that contrib/netbsd-tests came from NetBSD, not FreeBSD. > Peter Holm and I tried our best to vet out the issues with the test > suite before integrating it in, but there might be issues due to > implementation discrepancies between FreeBSD and NetBSD. The high-level question is whether these are conformance tests (in which = case they should be checking for specified behaviour) or regression = tests (in which case they should be checking for known implementation = details, but should explicitly document what those are). When the gettimeofday implementation changed, it would have been nice to = get two results: - No conformance tests failed, change is still a valid implementation of = POSIX gettimeofday() - One regression test failed. This test is assuming that gettimeofday() = is a system call and so should be marked as an expected failure. Unfortunately, the test suite currently conflates the two. David