From owner-freebsd-ports@FreeBSD.ORG Thu Feb 9 03:04:02 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F046B106566B; Thu, 9 Feb 2012 03:04:01 +0000 (UTC) (envelope-from pgollucci@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7F2DE8FC0C; Thu, 9 Feb 2012 03:04:01 +0000 (UTC) Received: by qaea17 with SMTP id a17so967469qae.13 for ; Wed, 08 Feb 2012 19:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:organization:user-agent:mime-version:to:cc :subject:references:in-reply-to:x-enigmail-version:content-type; bh=k7DQTrRnqFjDjbrO3t4VzHqswnt7uDb+2euZzI8EhHQ=; b=nJdrrCA9d8vpajy3jfGBpVGuZePLYD0ZLqbd840Y1xFvoaWFfPxneEmt4mqNQBsw0P uivN0o0U6ckS8PIigDt7tFLf/BjjMUTemutiV/uSKP0/F0/CqrQSVhBTGUEvDd/ad4CG VIyQe3zqKahhupNmadPmPNqceENBVoQdsHbAs= Received: by 10.224.184.79 with SMTP id cj15mr279579qab.78.1328756640753; Wed, 08 Feb 2012 19:04:00 -0800 (PST) Received: from philip.hq.rws (wsip-174-79-184-239.dc.dc.cox.net. [174.79.184.239]) by mx.google.com with ESMTPS id m20sm2886812qaj.14.2012.02.08.19.03.58 (version=SSLv3 cipher=OTHER); Wed, 08 Feb 2012 19:03:59 -0800 (PST) Message-ID: <4F33379B.5080804@p6m7g8.com> Date: Thu, 09 Feb 2012 03:03:55 +0000 From: "Philip M. Gollucci" Organization: P6M7G8 Inc. User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:7.0.1) Gecko/20111029 Thunderbird/7.0.1 MIME-Version: 1.0 To: Doug Barton References: <4F31EBE1.8040000@FreeBSD.org> <4F32966F.2070802@FreeBSD.org> <4F330438.9020800@FreeBSD.org> In-Reply-To: <4F330438.9020800@FreeBSD.org> X-Enigmail-Version: undefined Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE8BC0CDA75BB39872E687DFA" Cc: FreeBSD ports list , Alex Dupre Subject: Re: What use is WWWDIR_REL? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2012 03:04:02 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE8BC0CDA75BB39872E687DFA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/08/12 23:24, Doug Barton wrote: > On 02/08/2012 07:36, Alex Dupre wrote: >> Doug Barton wrote: >>> So this leads me to many questions, the first and most obvious of whi= ch >>> is, what the heck good is WWWDIR_REL in the first place? >> >> I don't follow you: in what sense WWWDIR_REL is different from, e.g., >> DOCSDIR_REL or DATADIR_REL? Why do you want to remove it and not the >> others? >=20 > Looking again at this bit of bpm: >=20 > PLIST_SUB+=3D DOCSDIR=3D"${DOCSDIR_REL}" \ > EXAMPLESDIR=3D"${EXAMPLESDIR_REL}" \ > DATADIR=3D"${DATADIR_REL}" \ > WWWDIR=3D"${WWWDIR_REL}" \ > ETCDIR=3D"${ETCDIR_REL}" >=20 > You're right, the silliness is universal. I was focused on WWWDIR > because I was working with it. They should probably all go away, but I > don't have the time atm to do an exhaustive search on where/how they ar= e > all used. >=20 >=20 > Doug >=20 Ah, the lightbulb goes off. pkg-plist is supposed to be relative to @cwd which may or may not be ${LOCALBASE} or ${PREFIX} hence abs paths should be avoided. That said, I think dougb's original patch + WWWDIR=3D"${WWWDIR:S,^${PREFIX}/,,}" accomplishes this quite nicely and removes 1-3 variables in the process. --=20 ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Director Operations, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. --------------enigE8BC0CDA75BB39872E687DFA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iD8DBQFPMzeedbiP+9ubjBwRAu34AKCMljI/jT/jL98ELbY2mUZgCaoSVgCggXer jnULCwemXrgkdDdqsxjZe10= =C6O/ -----END PGP SIGNATURE----- --------------enigE8BC0CDA75BB39872E687DFA--