From owner-freebsd-current@FreeBSD.ORG  Sun Dec 12 00:58:14 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5D8C816A4CE
	for <freebsd-current@freebsd.org>;
	Sun, 12 Dec 2004 00:58:14 +0000 (GMT)
Received: from pacha.mail.bishopston.net (pacha.mail.bishopston.net
	[66.221.209.133])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2389443D39
	for <freebsd-current@freebsd.org>;
	Sun, 12 Dec 2004 00:58:14 +0000 (GMT)
	(envelope-from jamie@bishopston.net)
X-Catflap-Envelope-From: <jamie@catflap.bishopston.net>
X-Catflap-Envelope-To: <freebsd-current@freebsd.org>
Received: from catflap.bishopston.net (jamie@localhost [127.0.0.1])
	by catflap.bishopston.net (8.13.1/8.13.1) with ESMTP id iBC0wEeh054370
	for <freebsd-current@freebsd.org>; Sun, 12 Dec 2004 00:58:14 GMT
	(envelope-from jamie@catflap.bishopston.net)
Received: (from jamie@localhost)
	by catflap.bishopston.net (8.13.1/8.12.9/Submit) id iBC0wD25054369
	for freebsd-current@freebsd.org; Sun, 12 Dec 2004 00:58:13 GMT
Date: Sun, 12 Dec 2004 00:53:11 GMT
From: Jamie Jones <jamie@bishopston.net>
Message-Id: <200412120053.iBC0rBBv048316@catflap.bishopston.net>
To: freebsd-current@freebsd.org
X-Scanned-By: milter-sender/0.62.837 (localhost [127.0.0.1]);
	Sun, 12 Dec 2004 00:58:14 +0000
cc: jamie@bishopston.net
cc: jay@evilrealms.net
Subject: bugs in ugen.h (and fix)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Dec 2004 00:58:14 -0000


Trying to get the SpeedTouch ADSL modem to work with Freebsd 5.3-RELEASE,
I got the kernel error:

 | pppoa2 : pusb_endpoint_open failed
 | 
 | WARNING: Driver mistake: destroy_dev on 238/1
 | 
 | panic: don't do that

After some googling, I found a patch to ugen.h by Jay Cornwall, that
was posted to freebsd-current exactly a year ago today:

http://unix.derkeiler.com/Mailing-Lists/FreeBSD/current/2003-12/1005.html

I applied this patch to the ugen.c that comes with 5.3-RELEASE (patching
manually to cope with the changes to ugen.c since his patch was posted)
and everything has been working like a charm ever since (over a week later)

I was just wondering why this patch was never committed to the tree,
and if it's just been overlooked, is there any reason why it can't be
applied now ?

For reference, my patched up 5.3-RELEASE version, based entirely on
Jays changed merged into the current 5.3-RELEASE version is here:

http://www.bishopston.com/jamie/freebsd/ugen.c-5.3-RELEASE-patched

Thanks,
Jamie