From owner-svn-src-all@FreeBSD.ORG Fri Jan 2 07:44:04 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 978861065691; Fri, 2 Jan 2009 07:44:04 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk1.360sip.com [72.236.70.240]) by mx1.freebsd.org (Postfix) with ESMTP id 5500F8FC23; Fri, 2 Jan 2009 07:44:04 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.28.129] (d75-157-251-204.bchsia.telus.net [75.157.251.204]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.8) with ESMTP id n027i13L093294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Jan 2009 23:44:02 -0800 (PST) (envelope-from sobomax@FreeBSD.org) Message-ID: <495DC5AF.3050908@FreeBSD.org> Date: Thu, 01 Jan 2009 23:43:43 -0800 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Doug Barton References: <200901011055.n01AtQaN052763@svn.freebsd.org> <495DB15B.8040908@FreeBSD.org> <495DB9B6.4030801@FreeBSD.org> In-Reply-To: <495DB9B6.4030801@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn: head/usr.sbin/mergemaster X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jan 2009 07:44:05 -0000 Doug Barton wrote: > Maxim Sobolev wrote: >> Doug Barton wrote: >>> Author: dougb >>> Date: Thu Jan 1 10:55:26 2009 >>> New Revision: 186677 >>> URL: http://svn.freebsd.org/changeset/base/186677 >>> >>> Log: >>> Revert 184781, 184804, and 184832 (automatic installation of files >>> that differ only by VCS Id) for the following reasons: >>> 1. It was added without my consent, review, or even a heads up >> Huh? I sent you request for review on 24 October 2008 > > If that's the case then I apologize, I've been extremely overloaded > lately and it's possible that this fell through the cracks. > > My other objections remain however, including the one about the -U > option being a better solution that requires no new code. 1. -U option requires system to have the copy of the database from the previous upgrade. It gives no help on the system that was installed from CD. 2. If the functionality has some issues leading to false positives I can investigate and improve/fix. 3. I don't see anything so technically bad about that feature (put aside implementation details). I would like to hear some of your principal objections. -Maxim