From owner-freebsd-net@FreeBSD.ORG Sun Nov 4 06:28:58 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2EF9735E for ; Sun, 4 Nov 2012 06:28:58 +0000 (UTC) (envelope-from julian@elischer.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) by mx1.freebsd.org (Postfix) with ESMTP id 01AD78FC08 for ; Sun, 4 Nov 2012 06:28:57 +0000 (UTC) Received: from [10.0.1.30] (adsl-70-231-139-202.dsl.snfc21.sbcglobal.net [70.231.139.202]) (authenticated bits=0) by vps1.elischer.org (8.14.5/8.14.5) with ESMTP id qA46SnXa051620 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sat, 3 Nov 2012 23:28:50 -0700 (PDT) (envelope-from julian@elischer.org) References: <570F1A37-38F0-41CF-91C7-B6047AA79E97@neville-neil.com> <3465231B-CEC2-4FC1-92EF-95C535EFCBED@xcllnt.net> In-Reply-To: <3465231B-CEC2-4FC1-92EF-95C535EFCBED@xcllnt.net> Mime-Version: 1.0 (1.0) Message-Id: <24AEFB78-C46F-4837-81E1-01250CA8666E@elischer.org> X-Mailer: iPad Mail (9B206) From: Julian Main Subject: Re: Proposal for changes to network device drivers and network stack (RFC) Date: Sat, 3 Nov 2012 23:28:44 -0700 To: Marcel Moolenaar Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "freebsd-net@freebsd.org" , Anuranjan Shukla X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Nov 2012 06:28:58 -0000 > > > I renamed the interface implementation from mumble_ddi.h to > if_device.[ch] and put a diff here: > http://people.freebsd.org/~marcel/Juniper/if_device.diff Looks reasonable to me. Gives some protection from API change But to really make use of this you could have driver specific methods... > > To see how it's used and/or how it changes a device driver, look > at a diff to if_em.c here: > http://people.freebsd.org/~marcel/Juniper/if_em.diff > > Some notes: > 1. Yes, there needs a license at the top. It's 2-clause BSD > 2. The function pointers are macros right now. I think it's > better to have an ops structure and a single function to > set the ops than a bunch of accessors to set functions. > 3. The code needs to be tidied up. > > What I'd like to see is a discussion on the functions themselves. > They're the result of looking at a single driver (or maybe 2 > drivers), and as such may not be perfectly generic or logical. > > As said before: we'd like to focus on an ABI-stable interface, > but a one based on macros should also be possible. > > Sorry for the delay, > > -- > Marcel Moolenaar > marcel@xcllnt.net > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"