From owner-svn-src-head@freebsd.org Tue Sep 3 14:07:36 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 89596DD6D8; Tue, 3 Sep 2019 14:07:13 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N80K27sVz4QN9; Tue, 3 Sep 2019 14:07:13 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 92C5C1B2B2; Tue, 3 Sep 2019 14:06:32 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 70EFDF7F6; Sat, 20 Apr 2019 17:23:11 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E5706B9D5; Sat, 20 Apr 2019 17:23:10 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 118B5F7AF; Sat, 20 Apr 2019 17:23:10 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 767FDF7A9 for ; Sat, 20 Apr 2019 17:23:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1F72B6B9CB for ; Sat, 20 Apr 2019 17:23:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x830.google.com with SMTP id v7so4794512qti.7 for ; Sat, 20 Apr 2019 10:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RkbNjvsXqcX+2/uBp8aX4R2YBGfjox9I/Og+lVXD4lM=; b=fWpdXHoLkkboTsd8Q7WTGvr0VPfr51bpV5jczFbM0WC6Ke5/hBH2XbD0tZiX9D7YCt 0PlCKG1cRm1ODRaJeiAHbdsazX+Ez2I0g3nVWcTnhYpggn582Ib9iW5KWy1i6dcTqzJ+ 8sRuL7T9f69p/+/lC/YdieSiuyR+mvywimbAfXgWBZW903h23kZxuoEJhe5N34dL3WSp zCq+WPEeQJrcqaOz8POrFF+ESMLVkaXNjV/aUN6B15pnKVwr9QSEVqckqSDD+EM7HFDL 1b8urznsp3Z1DrktniibBZMryk6afWnVeVCIKfG/eaNkz9XzL2MPiJIMr7Tycnz7W7Sz +2uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RkbNjvsXqcX+2/uBp8aX4R2YBGfjox9I/Og+lVXD4lM=; b=jSFNvrba51Cdhv0rNxD9xjtKxPCZ1I/wG5QaaH3Lspg8dioUHRRYJ/amYiUxahuWZ/ ZC3bmINoa1hSmmxwNm11jz2hYZdhny/8eW03HVnzdf0r6rBS/vB9/oXUlLZGjtfHQeHT 8YVET1zYcNw5zDyN21YolunR3+coGLetzLyKsAhHErKdRAQxHJYbI/5/0Do/YKD7mv8w n5KP+va7gxV8OgLEoJciLkgymF0KUI/xAXeGlntTJHZ1WuYxhb0HtL8FUV2o5LXo6H3f 1LOJC8FJ4zZ7Dgy4KXqbmuSwq5fjcrX4PZuti1ybPq9C25I75GNIMNCngdakvt+yTope Cidg== X-Gm-Message-State: APjAAAXCecPZMZrrJ6fUG/jh7qbM2fFlbCeJ8k2+Oh1XEoSjWTIZ6ccB WnQYXRzrhhq6X8XqK0y/DuEDsSOnjL/Y12l7M5DfsA== X-Google-Smtp-Source: APXvYqxE7L+RFUhuptMvfiINdkWNV6SYYi4JS35NAkCh1ssbKdTxorab3hwu1fjz4Sp6wIImO7A1pJ5joAJ91feWrh0= X-Received: by 2002:ac8:1e0c:: with SMTP id n12mr2779062qtl.33.1555780986533; Sat, 20 Apr 2019 10:23:06 -0700 (PDT) MIME-Version: 1.0 References: <201904201251.x3KCp6it044898@repo.freebsd.org> <5bf4a702-7df8-5597-25b0-55baa71d1d4f@FreeBSD.org> <16BC7A31-39F3-4CFE-A6DA-5187FB154FA4@gmail.com> In-Reply-To: <16BC7A31-39F3-4CFE-A6DA-5187FB154FA4@gmail.com> From: Warner Losh Message-ID: Subject: Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf To: Garrett Cooper Cc: John Baldwin , Justin Hibbits , Alan Somers , src-committers , svn-src-all , svn-src-head Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 9E5706B9D5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.964,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:36 -0000 X-Original-Date: Sat, 20 Apr 2019 11:22:54 -0600 X-List-Received-Date: Tue, 03 Sep 2019 14:07:36 -0000 On Sat, Apr 20, 2019, 10:46 AM Enji Cooper wrote: > > > > On Apr 20, 2019, at 9:44 AM, John Baldwin wrote: > > > > On 4/20/19 6:23 AM, Justin Hibbits wrote: > >> On Sat, Apr 20, 2019, 08:21 Alan Somers wrote: > >> > >>> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits > >>> wrote: > >>>> > >>>> > >>>> > >>>> On Sat, Apr 20, 2019, 07:51 Alan Somers wrote: > >>>>> > >>>>> Author: asomers > >>>>> Date: Sat Apr 20 12:51:05 2019 > >>>>> New Revision: 346441 > >>>>> URL: https://svnweb.freebsd.org/changeset/base/346441 > >>>>> > >>>>> Log: > >>>>> Use symlinks for kernel modules rather than hardlinks > >>>>> > >>>>> When aliasing a kernel module to a different name (ie if_igb for > >>> if_em), > >>>>> it's better to use symlinks than hard links. kldxref will omit > >>> entries for > >>>>> the links, ensuring that the loaded module has the correct name. > >>>>> > >>>>> > >>>> > >>>> > >>>> Thanks! This should fix installkernel on my POWER9. > >>>> > >>>> - Justin > >>> > >>> What's the problem with your POWER9? Is that one of those msdosfs > >>> /boot systems? If so, I don't think this will fix it. msdosfs > >>> doesn't support either symlinks or hardlinks. Or is there some other > >>> problem? > >>> -Alan > >>> > >> > >> Yes it is. Well that's a bummer then. I thought we faked symlinks on > >> msdosfs, but on second thought not sure how well would do that. > > > > You could just use cp instead of a link? > > *eyes `install -l`*: > > -l linkflags > Instead of copying the file make a link to the source. The > type > of the link is determined by the linkflags argument. Valid > linkflags are: a (absolute), r (relative), h (hard), s > (symbolic), m (mixed). Absolute and relative have effect only > for symbolic links. Mixed links are hard links for files on > the > same filesystem, symbolic otherwise. > None of those are helpful. Better to just not do the link for a system we don't the compat links for.... Warner Cheers, > -Enji > >