Date: Thu, 14 Apr 2022 07:21:17 GMT From: Navdeep Parhar <np@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 239170f29210 - main - cxgbe(4): Fix control flow issues reported by Coverity. Message-ID: <202204140721.23E7LHvv048851@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=239170f29210a21a68284dc967e57ed8047fb2ba commit 239170f29210a21a68284dc967e57ed8047fb2ba Author: Navdeep Parhar <np@FreeBSD.org> AuthorDate: 2022-04-14 07:17:36 +0000 Commit: Navdeep Parhar <np@FreeBSD.org> CommitDate: 2022-04-14 07:17:36 +0000 cxgbe(4): Fix control flow issues reported by Coverity. CID 1487932: Control flow issues (NESTING_INDENT_MISMATCH). The macro on this line expands into multiple statements, only the first of which is nested within the preceding parent while the rest are not. 9828 ulp_region(RX_TLS_KEY); Reported by: Coverity (CID 1487932) Fixes: f88b31885c4 cxgbe(4): meminfo should get the TLS region's limits from the hardware. MFC after: 3 days Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index eba79deeced3..b4069119c167 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9824,8 +9824,9 @@ sysctl_meminfo(SYSCTL_HANDLER_ARGS) ulp_region(RX_RQUDP); ulp_region(RX_PBL); ulp_region(TX_PBL); - if (sc->cryptocaps & FW_CAPS_CONFIG_TLSKEYS) + if (sc->cryptocaps & FW_CAPS_CONFIG_TLSKEYS) { ulp_region(RX_TLS_KEY); + } #undef ulp_region md->base = 0;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204140721.23E7LHvv048851>