From owner-freebsd-ports@FreeBSD.ORG  Fri Jan 11 06:15:40 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DB88416A41B;
	Fri, 11 Jan 2008 06:15:40 +0000 (UTC)
	(envelope-from james.cook@utoronto.ca)
Received: from toq5-srv.bellnexxia.net (toq5-srv.bellnexxia.net
	[209.226.175.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 602F213C448;
	Fri, 11 Jan 2008 06:15:40 +0000 (UTC)
	(envelope-from james.cook@utoronto.ca)
Received: from toip7.srvr.bell.ca ([209.226.175.124])
	by tomts22-srv.bellnexxia.net
	(InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id
	<20080111055500.VKWP18413.tomts22-srv.bellnexxia.net@toip7.srvr.bell.ca>;
	Fri, 11 Jan 2008 00:55:00 -0500
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Ao8CAMqThkdBX36a/2dsb2JhbACqGAM
Received: from bas4-toronto63-1096777370.dsl.bell.ca (HELO glider)
	([65.95.126.154])
	by toip7.srvr.bell.ca with SMTP; 11 Jan 2008 00:56:18 -0500
Received: by glider (sSMTP sendmail emulation); Fri, 11 Jan 2008 00:54:39 -0500
Date: Fri, 11 Jan 2008 00:54:39 -0500
From: James Cook <james.cook@utoronto.ca>
To: Kris Kennaway <kris@freebsd.org>
Message-ID: <20080111055439.GA1502@glider>
References: <20080110174126.GA45584@glider>
	<18310.35480.307764.676937@jerusalem.litteratus.org>
	<478697BF.5020604@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <478697BF.5020604@FreeBSD.org>
User-Agent: Mutt/1.4.2.3i
Cc: ports@freebsd.org, james.cook@utoronto.ca, Robert Huff <roberthuff@rcn.com>
Subject: Re: freebsd-games: hack needs -fwritable-strings
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2008 06:15:40 -0000

On Thu, Jan 10, 2008 at 11:10:07PM +0100, Kris Kennaway wrote:
> Robert Huff wrote:
> >James Cook writes:
> >
> >> This seems to be caused by line 170 of hack.u_init.c, which
> >> attempts to modify a string constant.
> >> 
> >> SOLUTION:
> >> Add -fwritable-strings to CFLAGS in hack's Makefile.  (There's
> >> already a patch that changes that line of the Makefile, so this
> >> is easy to change.)
> >
> >	Has something changed in the definition of correctly written
> >code while I was away at the funny farm?  Why is the solution not
> >"Don't modify a costant."? 
> 
> This code has been largely untouched since the 1980s :)
> 
> Kris

I like to think of the code as a museum artifact.  An age-old scroll,
written in an archaic language just close enough to modern C for us
to understand.

The original form will always be preserved somewhere, though.  If somebody
has the energy to modernize the code, I'm happy.

James