From owner-svn-src-all@FreeBSD.ORG  Wed Jan 19 13:23:53 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 76D58106566B;
	Wed, 19 Jan 2011 13:23:53 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4674A8FC1B;
	Wed, 19 Jan 2011 13:23:53 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id E423046B66;
	Wed, 19 Jan 2011 08:23:52 -0500 (EST)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1A9778A009;
	Wed, 19 Jan 2011 08:23:52 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Peter Jeremy <peterjeremy@acm.org>
Date: Wed, 19 Jan 2011 08:15:40 -0500
User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; )
References: <201101181523.p0IFNGeB042079@svn.freebsd.org>
	<20110119055635.GA90983@server.vk2pj.dyndns.org>
In-Reply-To: <20110119055635.GA90983@server.vk2pj.dyndns.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201101190815.40908.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Wed, 19 Jan 2011 08:23:52 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham
	version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r217538 - in head/sys/dev: buslogic cs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jan 2011 13:23:53 -0000

On Wednesday, January 19, 2011 12:56:35 am Peter Jeremy wrote:
> On 2011-Jan-18 15:23:16 +0000, John Baldwin <jhb@FreeBSD.org> wrote:
> >Log:
> >  Remove some always-true comparisons.
> ...
> >--- head/sys/dev/cs/if_cs.c	Tue Jan 18 14:58:44 2011	(r217537)
> >+++ head/sys/dev/cs/if_cs.c	Tue Jan 18 15:23:16 2011	(r217538)
> >@@ -364,7 +364,7 @@ cs_cs89x0_probe(device_t dev)
> > 
> > 	if (!error && !(sc->flags & CS_NO_IRQ)) {
> > 		if (chip_type == CS8900) {
> >-			if (irq >= 0 || irq < 16)
> >+			if (irq < 16)
> > 				irq = cs8900_irq2eeint[irq];
> > 			else
> > 				irq = 255;
> 
> Irrespective of the signedness or otherwise of "irq", I'm fairly
> certain that '||' should have been '&&' before.

Agreed.

-- 
John Baldwin