From owner-svn-src-head@freebsd.org Wed Jul 12 08:09:42 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46E69DB5AE3; Wed, 12 Jul 2017 08:09:42 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-wr0-x232.google.com (mail-wr0-x232.google.com [IPv6:2a00:1450:400c:c0c::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E3ADB7E4D8; Wed, 12 Jul 2017 08:09:41 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-wr0-x232.google.com with SMTP id c11so22523755wrc.3; Wed, 12 Jul 2017 01:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HvWo7n1N4TbDRQHKM7dO4jOrjlalYDz7WrqehRBfNxM=; b=kMcys1lRNA4OwNMnfp3pOhPO7xWWyum8rzRXOEyz6GyyU5DrmPE5NOEP1hMmGEKKp/ aVGfetezFmu5BpeF66PJqwjxwFQqM/Zh/U1EqRnNDRAHmhlos3y4mewI+9MDB5R3GhZu TuZ8cG38bNzLvCJ5JnvoD+33okTUIAGxZ10a392ugkxxI3JdhdTzNnhsHMYMZcktzD/P v4V+U+muGQpRkUzk4ziASp1atVz3Lz7eLlbflaMlwcKDVEujp/AFU2b/K3jSZxOhk0Ve 38hN/1VGos4Hvml/cfFh2evR2ruUFT/cu4UEGZHBgIXVp2+jVwvrqlNKIb3NqyTviSAi ttjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HvWo7n1N4TbDRQHKM7dO4jOrjlalYDz7WrqehRBfNxM=; b=lkrs0RC3uEzbjGxDrJ8s4luaZle2C3O1fa9eE/F/+uFbHUMLTNvTW0jbTGNdbaz6kd paBdKedoDBeKXPzT1b44iTud2xQGqcp3o4yhkS7Ws2jYqI+mvmP1pOAX7z6K1KsMRebh isF8fmGGl4VIDtigUHgGs+5Rp1WsEUJdoGob++6o85ahEAXti9i2+JbWgICX5Nvz/b7w JiTNsafuypUydZRic8EuuWOIX0RZT3TEoCuvL55vFEHwKCJM4GQkbyUZxPuyro4zsQIP SEAhLlunqEj8QsQPz1f85NvRTklwT/o3E2xXR1k0VZCYO5eRf569eFNdEJm4XpbFViVk SCTg== X-Gm-Message-State: AIVw112eYnje1FEEwcH4dz2u9QoHoqHX6htcUnCT68lDMnkGZIpfeUQu FuHg8Mb5972jX7XsgM4vCX7ziPK3ijg4 X-Received: by 10.28.9.205 with SMTP id 196mr1543707wmj.126.1499846979939; Wed, 12 Jul 2017 01:09:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.161.81 with HTTP; Wed, 12 Jul 2017 01:09:39 -0700 (PDT) In-Reply-To: <20170712074326.GA41347@vlakno.cz> References: <201707120730.v6C7UExf041447@repo.freebsd.org> <20170712074326.GA41347@vlakno.cz> From: Ryan Libby Date: Wed, 12 Jul 2017 01:09:39 -0700 Message-ID: Subject: Re: svn commit: r320908 - head/sys/kern To: Roman Divacky Cc: Ryan Libby , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 08:09:42 -0000 On Wed, Jul 12, 2017 at 12:43 AM, Roman Divacky wrote: > Clang knows about %b modifier and can do some semantic analysis on it. > Currently it type checks the first arg to be an int and the second to be > a char*. > > Do you think it would be worth modifying the checks to include > this new functionality? Do you think you would like to take a stab > at it? Yes, I plan to send that to clang upstream. I originally had those changes in this commit but I was directed rather to send them first to upstream. See here [1] for roughly what I plan to send upstream (although I have since noticed some unit tests that I guess should be extended). For now, the semantic analysis should be fine as the change should be backward compatible and I haven't yet changed any of the users of %b to use the new capabilities. Ryan [1] https://reviews.freebsd.org/D11284?id=29866